LibWeb: Fix new ImageData(width, height) when width != height

awesomekling · Apr 15, 2024 · fc7ced5 · fc7ced5
1 parent 026860c
commit fc7ced5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/Tests/LibWeb/Text/expected/HTML/ImageData-create-with-size.txt b/Tests/LibWeb/Text/expected/HTML/ImageData-create-with-size.txt
diff --git a/Tests/LibWeb/Text/input/HTML/ImageData-create-with-size.html b/Tests/LibWeb/Text/input/HTML/ImageData-create-with-size.html
@@ -6,6 +6,10 @@
         println(imageData.data);
         println(imageData.data.length);
 
+        imageData = new ImageData(1, 2);
+        println(imageData.data);
+        println(imageData.data.length);
+
         const arr = new Uint8ClampedArray(40_000);
         // Fill the array with the same RGBA values
         for (let i = 0; i < arr.length; i += 4) {

diff --git a/Userland/Libraries/LibWeb/HTML/ImageData.cpp b/Userland/Libraries/LibWeb/HTML/ImageData.cpp
@@ -73,7 +73,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<ImageData>> ImageData::create(JS::Realm& re
         return WebIDL::IndexSizeError::create(realm, "Source height must be equal to the calculated height of the data."_fly_string);
 
     // 7. Initialize this given sw, sh, settings set to settings, and source set to data.
-    auto bitmap = TRY_OR_THROW_OOM(vm, Gfx::Bitmap::create_wrapper(Gfx::BitmapFormat::RGBA8888, Gfx::IntSize(sw, sw), 1, sw * sizeof(u32), uint8_clamped_array_data.data().data()));
+    auto bitmap = TRY_OR_THROW_OOM(vm, Gfx::Bitmap::create_wrapper(Gfx::BitmapFormat::RGBA8888, Gfx::IntSize(sw, height), 1, sw * sizeof(u32), uint8_clamped_array_data.data().data()));
 
     return realm.heap().allocate<ImageData>(realm, realm, bitmap, uint8_clamped_array_data);
 }