-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add desired tasks #505
Conversation
@clareliguori could i ask for help to solve issue with test? |
Hello @romankydybets ! Thanks for the PR! Is there some error you are getting when running the tests? can you paste the error over here? |
@KollaAdithya
|
Hi @romankydybets !
|
thank you @KollaAdithya, did a fix, please take a look. |
Is there any updates on this? |
Any updates? |
@clareliguori could you please review? |
* add desired count * add desired count * add desired count * fix test for desired count * small change * update dist/index.js * address feedback @iamhopaul123 * update dist/index.js --------- Co-authored-by: Adithya Kolla <kolladit@amazon.com>
@KollaAdithya @iamhopaul123 Is it possible to publish a new release? |
Please could this be released, it's very useful! |
* add desired count * add desired count * add desired count * fix test for desired count * small change * update dist/index.js * address feedback @iamhopaul123 * update dist/index.js --------- Co-authored-by: Adithya Kolla <kolladit@amazon.com>
I would like to ask for help in the PR, as I can't fix 1 test which is failing.
Issue #499
Add support for DesiredCount
it would be great to have DesiredCount support during deployment.
https://docs.aws.amazon.com/cli/latest/reference/ecs/update-service.html
--desired-count
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.