-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new options to fetch task definition #311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkhegde
reviewed
Jul 23, 2024
omkhegde
reviewed
Jul 23, 2024
s3cube
reviewed
Jul 23, 2024
s3cube
reviewed
Jul 24, 2024
amazreech
reviewed
Jul 26, 2024
amazreech
reviewed
Jul 26, 2024
amazreech
reviewed
Jul 26, 2024
amazreech
reviewed
Jul 29, 2024
amazreech
reviewed
Jul 29, 2024
amazreech
added
do-not-merge
Label to block automatic merge from dependabot
and removed
do-not-merge
Label to block automatic merge from dependabot
labels
Jul 29, 2024
amazreech
reviewed
Jul 30, 2024
amazreech
reviewed
Jul 31, 2024
amazreech
reviewed
Aug 1, 2024
amazreech
reviewed
Aug 1, 2024
omkhegde
approved these changes
Aug 1, 2024
amazreech
reviewed
Aug 1, 2024
amazreech
reviewed
Aug 1, 2024
amazreech
reviewed
Aug 1, 2024
amazreech
reviewed
Aug 1, 2024
amazreech
reviewed
Aug 1, 2024
amazreech
approved these changes
Aug 1, 2024
…inputs, and refactored code to handle new inputs and error cases."
Hi! Thank you for mentioning us but I wonder if we should appear as code contributors or at least Filipe who did the most hard work.
Enviado do meu iPhone
Em 1 de ago. de 2024, à(s) 16:37, Sherlyn ***@***.***> escreveu:
Issue #, if available: #102<#102> and #518<https://github.com/aws-actions/amazon-ecs-deploy-task-definition/pull/518/files>
Description of changes: fetch task definition now through task definition file, task definition ARN, task definition family and task definition revision.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
…________________________________
These changes borrow from PR #518<https://github.com/aws-actions/amazon-ecs-deploy-task-definition/pull/518/files> authored by Filipe Macedo ( @filipemacedo<https://github.com/filipemacedo> ) and Fábio BC Souza ( @fabiobarboza7<https://github.com/fabiobarboza7> ).
________________________________
You can view, comment on, or merge this pull request online at:
#311
Commit Summary
* ead9e6e<ead9e6e> "Updated action to support task definition ARN, family, and revision inputs, and refactored code to handle new inputs and error cases."
* 9b832c3<9b832c3> updated index.js dist file
* 8d06dc2<8d06dc2> updated package.json file and lock.json
* 4296835<4296835> updated dist file with installed sdk package
* dfc9416<dfc9416> updated code with first round of comments
* c7d4ac6<c7d4ac6> modified code with suggested comments and tests
* 5a9a914<5a9a914> modified code for testing cases
* 9071bd0<9071bd0> new changes from suggested comments
* 2564353<2564353> chnages made from comments and spacing fixing
* 226cef4<226cef4> removing . promise from describeTaskDef call
* 9035582<9035582> removing . promise and then from describeTaskDef call
* cd8e03d<cd8e03d> updated describe tasl def api call
* bba239a<bba239a> fixed api call
* 79dc9fc<79dc9fc> fixed api call and removing data
* 1c8853c<1c8853c> fixed api and moved call
* 978db7a<978db7a> fixed spacing and indentation: final edits
* e79fac8<e79fac8> fixed spacing for task definition revision
* 373792b<373792b> fixed spacing and descriptions
* 84e21b9<84e21b9> ploishing code with suggested comments
* e60b4fe<e60b4fe> adding small changes for new input default values
* 9889776<9889776> fixing spacing
* ab92dfe<ab92dfe> fixing indentation for task definition file conditional block
* c1844ba<c1844ba> fixing indentation for one space
* b095c52<b095c52> changes after suggested comments for description and organization
File Changes
(7 files<https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/311/files>)
* M README.md<https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/311/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5> (6)
* M action.yml<https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/311/files#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6> (11)
* M dist/index.js<https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/311/files#diff-3d2b59189eeedc2d428ddd632e97658fe310f587f7cb63b01f9b98ffc11c0197> (24592)
* M index.js<https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/311/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346> (62)
* M index.test.js<https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/311/files#diff-59e25b254be93038f106111be580b6fb54c6963b6c4e7ef744e58fb8f2b3e3a2> (345)
* M package-lock.json<https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/311/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519> (2280)
* M package.json<https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/311/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519> (1)
Patch Links:
* https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/311.patch
* https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/311.diff
—
Reply to this email directly, view it on GitHub<#311>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJQS36RPYRUCAEIIQKPAU33ZPKE6DAVCNFSM6AAAAABLLBWPQOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZDKOJVGQZTEMY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi @fabiobarboza7, I have mentioned you and Filipe in both this PR description and in the code commit itself as contributor. Code commit: e246ecd. Do let me know if there is anywhere else I could add both of you as contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #102 and #518
Description of changes: fetch task definition now through task definition file, task definition ARN, task definition family and task definition revision.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
These changes borrow from PR #518 authored by Filipe Macedo ( @filipemacedo ) and Fábio BC Souza ( @fabiobarboza7 ).