-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get tags and clean attributes #325
base: master
Are you sure you want to change the base?
Conversation
Landed on this PR while trying to figure out why our new task definitions are not showing up existing tags. Would be great if this gets merged! |
@guikcd Do you have any ball park timeline for merging it? |
Not yet I didn't re-work on it since weeks. I was stuck on unit test; when I remove the added code, the tests with tags still pass. Seems that the test already pass unnecessary fields that are cleaned (in the test). |
This is golden! Running a fork with similar changes today, would really love to get rid of that 😄 |
Is there anything we can do to help get this merged? |
I think I don't master the unit test part. Note that the code behave well in real functional test cases. |
Issue #, if available:
Closes: #317
Description of changes:
Note: Most of clean code/logic/functions come from https://github.com/aws-actions/amazon-ecs-deploy-task-definition project.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.