Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get tags and clean attributes #325

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

guikcd
Copy link

@guikcd guikcd commented Sep 2, 2024

Issue #, if available:
Closes: #317

Description of changes:

  • Clean unnecessary attributes
  • Include tag: to give possibility to propagate them for the next runTask/UpdateService step (TASK_DEFINITION)

Note: Most of clean code/logic/functions come from https://github.com/aws-actions/amazon-ecs-deploy-task-definition project.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@guikcd guikcd marked this pull request as draft September 2, 2024 14:22
@siddharth7
Copy link

Landed on this PR while trying to figure out why our new task definitions are not showing up existing tags. Would be great if this gets merged!

@siddharth7
Copy link

@guikcd Do you have any ball park timeline for merging it?

@guikcd
Copy link
Author

guikcd commented Oct 16, 2024

Not yet I didn't re-work on it since weeks. I was stuck on unit test; when I remove the added code, the tests with tags still pass. Seems that the test already pass unnecessary fields that are cleaned (in the test).

@jebl01
Copy link

jebl01 commented Oct 24, 2024

This is golden! Running a fork with similar changes today, would really love to get rid of that 😄

@domalee domalee marked this pull request as ready for review November 11, 2024 15:08
@anitakrueger
Copy link

Is there anything we can do to help get this merged?

@guikcd
Copy link
Author

guikcd commented Nov 13, 2024

I think I don't master the unit test part. Note that the code behave well in real functional test cases.
But for example, if I remove the tag code I've added previously and let the tags test, the unit test still pass. I'm probably missing something and as I'm not very experienced in jest (also in {Type,Java}Script) I need help to verify the tests are accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download tags and cleanup unneeded properties from downloaded task definition
4 participants