chore: Add more devices to integration testing #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdhuka
reviewed
Aug 12, 2022
scripts/run_test_in_devicefarm.sh
Outdated
| {"attribute":"AVAILABILITY","operator":"EQUALS","values":["HIGHLY_AVAILABLE"]}, | ||
| {"attribute":"PLATFORM","operator":"EQUALS","values":["ANDROID"]}, | ||
| {"attribute":"OS_VERSION","operator":"GREATER_THAN_OR_EQUALS","values":["7"]}, | ||
| {"attribute":"OS_VERSION","operator":"LESS_THAN","values":["8"]}, |
There was a problem hiding this comment.
Could the LESS_THAN = 7.1 so it run on API 24 which is our min supported version in dev-preview?
…:aws-amplify/amplify-android into tjroach/run-integration-multiple-devices
gpanshu
approved these changes
Aug 19, 2022
sdhuka
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing all PRs on 3 devices (Pixel or Samsung) with different OS versions now, instead of just 1.
Android 7
Android 10
Android 12
Also raised threshold to check every 20 seconds instead of 5. Will probably bump further in future PR.
How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.