Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): pk field list ordering in cascade delete. #1894

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

poojamat
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Fixing test failure because of list ordering.
How did you test these changes?
(Please add a line here how the changes were tested)

  • Added Unit Tests
  • Added Integration Tests

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@poojamat poojamat requested review from a team as code owners August 17, 2022 22:35
@tylerjroach
Copy link
Member

The change is in real code, not a test? Is this just a test failure?

@poojamat
Copy link
Contributor Author

The change is in real code, not a test? Is this just a test failure?
Its caught in test but failure might occur on production code.

@tylerjroach
Copy link
Member

@poojamat Especially sine this is a bug, can you correct PR title?
fix(category): description of changes

@poojamat poojamat changed the title Fixing test failure because of list ordering. Fix(datastore) pk field list ordering in cascade delete. Aug 18, 2022
@poojamat poojamat merged commit 0f82095 into main Aug 18, 2022
@poojamat poojamat deleted the integration_test_fix branch August 18, 2022 21:57
@sktimalsina sktimalsina changed the title Fix(datastore) pk field list ordering in cascade delete. fix(datastore): pk field list ordering in cascade delete. Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants