Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Fix for when a General Security Exception is thrown due to tink error we will recreate the preference #2623

Closed
wants to merge 2 commits into from

Conversation

gpanshu
Copy link
Contributor

@gpanshu gpanshu commented Nov 6, 2023

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: #2548

Description of changes: This is a rare crash that can occur in the Google Tink + EncryptedSharedPreferences library. In order for Amplify to function properly, we rely on EncryptedSharedPreferences to securely hold data. This issue can be found in the Google IssueTracker here: https://issuetracker.google.com/issues/176215143

If the master key becomes unreadable or corrupt the only path forward is to delete and recreate the preferences. This is a destructive action.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gpanshu gpanshu self-assigned this Nov 6, 2023
@gpanshu gpanshu linked an issue Nov 6, 2023 that may be closed by this pull request
1 task
@gpanshu gpanshu marked this pull request as ready for review November 13, 2023 20:32
@gpanshu gpanshu changed the title *DO NOT REVIEW* fix(auth): Fix for when a General Security Exception is thrown due to tink error we will recreate the preference fix(auth): Fix for when a General Security Exception is thrown due to tink error we will recreate the preference Nov 13, 2023
@gpanshu gpanshu enabled auto-merge (squash) November 13, 2023 20:32
@gpanshu gpanshu requested a review from a team as a code owner November 13, 2023 20:33
@gpanshu gpanshu marked this pull request as draft December 20, 2023 18:32
auto-merge was automatically disabled December 20, 2023 18:32

Pull request was converted to draft

@mattcreaser
Copy link
Member

Superseded by #2686

@mattcreaser mattcreaser deleted the fix-encryptedkeystorecorruption branch January 23, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AndroidKeystoreAesGcm.encryptInternal error GeneratedMessageLite.parsePartialFrom error
2 participants