Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apollo): Fix publishing errors with apollo-appsync #2913

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
The signing key was only being set for Android projects, resulting in no signature generating for apollo-appsync. You need signature files to publish the artifacts to maven central. Therefore I moved the setting of the required extras outside the check for the Android plugin.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner September 9, 2024 18:19
@mattcreaser mattcreaser enabled auto-merge (squash) September 9, 2024 18:21
@mattcreaser mattcreaser merged commit e605a14 into main Sep 9, 2024
4 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/apollo-publishing-signature branch September 9, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants