Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apollo): Use HTTP headers instead of query parameters for authorization #2916

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
AppSync recently added the ability to use HTTP headers instead of query parameters to authorize the websocket connection request. This is now the recommended way to connect (and new AppSync instances will eventually stop accepting query parameters).

This change switches the apollo-appsync library to use this new method of authorization.

How did you test these changes?

  • Added unit tests
  • Manual test passes
  • Integration tests still pass

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner September 16, 2024 18:38
vincetran
vincetran previously approved these changes Sep 16, 2024
@mattcreaser mattcreaser force-pushed the mattcreaser/appsync-auth-header-apollo branch from 4a644f2 to bfb3cf9 Compare September 18, 2024 18:01
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.01%. Comparing base (7f874ed) to head (bfb3cf9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2916      +/-   ##
==========================================
- Coverage   44.01%   44.01%   -0.01%     
==========================================
  Files         926      931       +5     
  Lines       30485    30688     +203     
  Branches     4351     4496     +145     
==========================================
+ Hits        13419    13507      +88     
- Misses      15601    15697      +96     
- Partials     1465     1484      +19     

@mattcreaser mattcreaser enabled auto-merge (squash) September 23, 2024 16:23
@mattcreaser mattcreaser merged commit aa6e1ff into main Sep 23, 2024
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/appsync-auth-header-apollo branch September 23, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants