Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth): Signout before tests start #2925

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
AWSCognitoAuthPluginInstrumentationTests fail very frequently on CI. I've made two changes to try to make this test class more robust:

  • Sign out before the test starts and sleep for 1 second before proceeding - this is to ensure we are actually in the correct state before starting the test
  • Unsubscribe from the Hub when the test finishes. This prevents the hub from accumulating listeners.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner September 20, 2024 19:47
@mattcreaser mattcreaser enabled auto-merge (squash) September 20, 2024 21:58
@mattcreaser mattcreaser merged commit 7d2a98f into main Sep 23, 2024
4 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/cognito-instrumentation-tests branch September 23, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants