feat(conversation): require auth input for conversation directive #3007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR
Problem
The
@conversation
directive implicitly uses owner auth (cognito user pool) for associated models and operations because it's the only supported option.In the future, we may want to extend conversation routes to additional authorization strategies. When that time comes, we'll be forced to make a decision between:
--- or ---
Description of changes
We're not going to support additional authorization strategies by GA, but we are making the decision to go with 2. breaking change (forcing explicit authorization definition) already. We're doing this now while we can so that we don't have to make a difficult decision later.
auth: ConversationAuth!
argument to@conversation
directive.The only supported strategy and provider for now are
owner
anduserPools
:Why not just use
@auth
?We could, but that would involve adding a check in the auth transformer that skipped any of it's work if the field also contained a
@conversation
directive. I'm not ok with doing that.CDK / CloudFormation Parameters Changed
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesRelevant documentation is changed or added (and PR referenced)New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policiesAny CDK or CloudFormation parameter changes are called out explicitlyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.