fix: make canary deps compatible with node 18 #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siqi-Shan
previously approved these changes
Dec 30, 2024
|
Manually started a canary workflow to verify. |
|
How did unaliasing default fix the issue? |
bobbyu99
previously approved these changes
Dec 30, 2024
Don't need that. Updated in latest commit. |
atierian
previously approved these changes
Dec 31, 2024
phani-srikar
changed the title
bobbyu99
previously approved these changes
Dec 31, 2024
Siqi-Shan
previously approved these changes
Dec 31, 2024
dpilch
previously approved these changes
Jan 2, 2025
phani-srikar
dismissed stale reviews from dpilch, Siqi-Shan, bobbyu99, and atierian
via
f2f4a4b
bobbyu99
approved these changes
Jan 2, 2025
atierian
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The transitive dependencies for the client canary test app now require atleast v20 node. This PR pins these deps to versions that allow us to test min CLI supported version i.e node 18.
CDK / CloudFormation Parameters Changed
Issue #, if available
Description of how you validated changes
Running
yarnwith updated version installs dependencies successfully.Also re-ran the canary flow with latest change and it succeeds.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.