Release API Category 9/14/22 #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal exceptions, and InvalidDirectiveExceptions for input errors
chore: remove all asserts in source code, replace with error for internal exceptions, and InvalidDirectiveExceptions for input errors
chore: refactor unit tests around owner auth warning, add a few more cases
* fix(api): gateway response dropping on update * update e2e test * remove it.only from api test
* chore: temp * refactor apart test utils * feat: refactor test into harness structure to simplify structure * adding api and datastore tests with more fleshed out model shapes * extending test suite * remove currently unused test apps, and remove files that should be gitignored, update gitignore * make generic builders for component types to extend to other models more quickly, add basic scaffolding for blog page * abstract edit/view away * refactor out to ModelHarness, and get a full set of hasmany tests working for Blog/Posts * move to new directory structure * revert changes not related to new test app * remove unused dep, update README.md Co-authored-by: Alexander Harris <ademp90@gmail.com>
* chore: bump cli core to next major version * update yarn.lock * fix: update category function
test(graphql): add negative test cases for invalid inputs and arguments
…the expression to construct aggregate values
…tors chore(amplify-graphql-searchable-transformer): refactor the expression to construct aggregate values
feat: enable running client tests as part of circle ci workflow
* Feature: enable deep merge default directive config with FF * Allow public subscriptions to be created * Tests: add tests for directive config merge * Fix value overwrite in unit tests * Correct some linting mistakes * Merge fixes * Remove lib imports, use options argument for getAuthRules * Fix call signature issues with getArguments * Fix feature flag reference * Default FF to false if not available * Correct bad test which was duplicating resolvers * Switch to generating get args inputs * Deep merge flag use const value in file * Fix usage of get auth rules feature flag * Add safety to directive wrapper args Clone default args before merge to prevent any accidental leakage between different calls Fix the isField value for object auth rules * Fix up imports * Fix lib import
* chore: no-op change to trigger pipelines (#545) * chore(release): Publish [ci skip] - @aws-amplify/amplify-category-api@3.1.1 - amplify-category-api-dynamodb-simulator@2.4.1 - amplify-category-api-e2e-core@4.0.1 - amplify-category-api-e2e-tests@3.10.1 - @aws-amplify/graphql-auth-transformer@0.11.0 - @aws-amplify/graphql-default-value-transformer@0.5.27 - @aws-amplify/graphql-function-transformer@0.7.21 - @aws-amplify/graphql-http-transformer@0.8.21 - @aws-amplify/graphql-index-transformer@0.12.0 - @aws-amplify/graphql-maps-to-transformer@1.1.19 - amplify-category-api-graphql-migration-tests@2.3.1 - @aws-amplify/graphql-model-transformer@0.14.5 - @aws-amplify/graphql-predictions-transformer@0.6.21 - @aws-amplify/graphql-relational-transformer@0.10.0 - @aws-amplify/graphql-schema-test-library@1.1.0 - @aws-amplify/graphql-searchable-transformer@0.14.5 - @aws-amplify/graphql-transformer-core@0.17.5 - @aws-amplify/graphql-transformer-interfaces@1.14.4 - @aws-amplify/graphql-transformer-migrator@1.4.0 - amplify-category-api-migration-tests@5.0.1 - amplify-category-api-util-mock@5.1.0 - graphql-auth-transformer@7.2.38 - graphql-connection-transformer@5.2.38 - graphql-dynamodb-transformer@7.2.38 - graphql-elasticsearch-transformer@5.2.38 - graphql-function-transformer@3.3.29 - graphql-http-transformer@5.2.38 - graphql-key-transformer@3.2.38 - graphql-predictions-transformer@3.2.38 - graphql-transformer-core@7.6.1 - amplify-category-api-graphql-transformers-e2e-tests@8.1.0 - graphql-versioned-transformer@5.2.38 * Added Windows compatible translation of "hoist-cli" script (#543) * fix(graphql): handle begin and end vtl keywords in index name (#510) * fix(graphql): handle begin and end vtl keywords in index name * updated comments * chore: cleanup stale s3 buckets, and remove references to amplify-app which we no longer leverage in our test suite (#556) * feature: add support for default generation of query and gsi names for @index directive behind a feature flag * fix(amplify-graphql-auth-transformer, amplify-graphql-relational-transformer, amplify-graphql-transformer-core): support custom primary key with relational directives (#462) * fix(amplify-graphql-auth-transformer, amplify-graphql-relational-transformer, amplify-graphql-transformer-core): support custom primary key with relational directives * fix: fixed refactor incorrect hanlding for filter vs connection input names * fix: merge build errors * fix: merge caused unit test failures * fix: merge caused e2e failures * fix: merge caused e2e failures * addressing PR feedback * fix: corrected allowed fields for relational fields with custom PK and restricted auth * fix: fixed imports and e2e feature flag initialization * Feat: Single Source Read This adds the capability for but does not enable single source reading on GraphQL schemas This is intended for GraphQL Transformer V2 without support for V1 This also required pulling apart some of the logic in schema transformation so I can actually instantiate the transformer elsewhere * Nit: early return statement for ease of reading * test(graphql): fix failing datastore modelgen tests (#575) * test(graphql): fix failing datastore modelgen tests * moved the amplify-app to e2e tests package * chore(release): Publish [ci skip] - @aws-amplify/amplify-category-api@3.1.2 - amplify-category-api-e2e-core@4.0.2 - amplify-category-api-e2e-tests@3.10.2 - @aws-amplify/graphql-auth-transformer@0.11.1 - @aws-amplify/graphql-default-value-transformer@0.5.28 - @aws-amplify/graphql-function-transformer@0.7.22 - @aws-amplify/graphql-http-transformer@0.8.22 - @aws-amplify/graphql-index-transformer@0.12.1 - @aws-amplify/graphql-maps-to-transformer@1.1.20 - amplify-category-api-graphql-migration-tests@2.3.2 - @aws-amplify/graphql-model-transformer@0.14.6 - @aws-amplify/graphql-predictions-transformer@0.6.22 - @aws-amplify/graphql-relational-transformer@0.10.1 - @aws-amplify/graphql-schema-test-library@1.1.1 - @aws-amplify/graphql-searchable-transformer@0.14.6 - @aws-amplify/graphql-transformer-core@0.17.6 - @aws-amplify/graphql-transformer-migrator@1.4.1 - amplify-category-api-migration-tests@5.0.2 - amplify-category-api-util-mock@5.1.1 - graphql-auth-transformer@7.2.39 - graphql-connection-transformer@5.2.39 - graphql-dynamodb-transformer@7.2.39 - graphql-elasticsearch-transformer@5.2.39 - graphql-function-transformer@3.3.30 - graphql-http-transformer@5.2.39 - graphql-key-transformer@3.2.39 - graphql-predictions-transformer@3.2.39 - graphql-relational-schema-transformer@2.21.9 - graphql-transformer-common@4.23.3 - graphql-transformer-core@7.6.2 - amplify-category-api-graphql-transformers-e2e-tests@8.1.1 - graphql-versioned-transformer@5.2.39 * fix: timestamp field sort in search queries (#581) * fix: timestamp field sort in search queries * address CRs * chore: change flag name for PK properties (#593) * chore: add build target to refresh lockfile, and refreshing lockfile * chore: improve error messaging if an invalid boolean sort key is provided to @index * feat(graphql): add runtime filtering support for subscriptions (#551) * feat(graphql): subscription runtime filtering * added dynamic groups support * update unit and e2e tests * added more test cases for auth precedence and different operators * fix enum list type on subscription filter * update model transformer screenshots * add test for enum field type * updated error message on a test * chore: remove unused dependencies based on depcheck report * chore: merge release to main (#616) * chore: no-op change to trigger pipelines (#545) * chore(release): Publish [ci skip] - @aws-amplify/amplify-category-api@3.1.1 - amplify-category-api-dynamodb-simulator@2.4.1 - amplify-category-api-e2e-core@4.0.1 - amplify-category-api-e2e-tests@3.10.1 - @aws-amplify/graphql-auth-transformer@0.11.0 - @aws-amplify/graphql-default-value-transformer@0.5.27 - @aws-amplify/graphql-function-transformer@0.7.21 - @aws-amplify/graphql-http-transformer@0.8.21 - @aws-amplify/graphql-index-transformer@0.12.0 - @aws-amplify/graphql-maps-to-transformer@1.1.19 - amplify-category-api-graphql-migration-tests@2.3.1 - @aws-amplify/graphql-model-transformer@0.14.5 - @aws-amplify/graphql-predictions-transformer@0.6.21 - @aws-amplify/graphql-relational-transformer@0.10.0 - @aws-amplify/graphql-schema-test-library@1.1.0 - @aws-amplify/graphql-searchable-transformer@0.14.5 - @aws-amplify/graphql-transformer-core@0.17.5 - @aws-amplify/graphql-transformer-interfaces@1.14.4 - @aws-amplify/graphql-transformer-migrator@1.4.0 - amplify-category-api-migration-tests@5.0.1 - amplify-category-api-util-mock@5.1.0 - graphql-auth-transformer@7.2.38 - graphql-connection-transformer@5.2.38 - graphql-dynamodb-transformer@7.2.38 - graphql-elasticsearch-transformer@5.2.38 - graphql-function-transformer@3.3.29 - graphql-http-transformer@5.2.38 - graphql-key-transformer@3.2.38 - graphql-predictions-transformer@3.2.38 - graphql-transformer-core@7.6.1 - amplify-category-api-graphql-transformers-e2e-tests@8.1.0 - graphql-versioned-transformer@5.2.38 * API Category Release (#587) * chore: no-op change to trigger pipelines (#545) * chore(release): Publish [ci skip] - @aws-amplify/amplify-category-api@3.1.1 - amplify-category-api-dynamodb-simulator@2.4.1 - amplify-category-api-e2e-core@4.0.1 - amplify-category-api-e2e-tests@3.10.1 - @aws-amplify/graphql-auth-transformer@0.11.0 - @aws-amplify/graphql-default-value-transformer@0.5.27 - @aws-amplify/graphql-function-transformer@0.7.21 - @aws-amplify/graphql-http-transformer@0.8.21 - @aws-amplify/graphql-index-transformer@0.12.0 - @aws-amplify/graphql-maps-to-transformer@1.1.19 - amplify-category-api-graphql-migration-tests@2.3.1 - @aws-amplify/graphql-model-transformer@0.14.5 - @aws-amplify/graphql-predictions-transformer@0.6.21 - @aws-amplify/graphql-relational-transformer@0.10.0 - @aws-amplify/graphql-schema-test-library@1.1.0 - @aws-amplify/graphql-searchable-transformer@0.14.5 - @aws-amplify/graphql-transformer-core@0.17.5 - @aws-amplify/graphql-transformer-interfaces@1.14.4 - @aws-amplify/graphql-transformer-migrator@1.4.0 - amplify-category-api-migration-tests@5.0.1 - amplify-category-api-util-mock@5.1.0 - graphql-auth-transformer@7.2.38 - graphql-connection-transformer@5.2.38 - graphql-dynamodb-transformer@7.2.38 - graphql-elasticsearch-transformer@5.2.38 - graphql-function-transformer@3.3.29 - graphql-http-transformer@5.2.38 - graphql-key-transformer@3.2.38 - graphql-predictions-transformer@3.2.38 - graphql-transformer-core@7.6.1 - amplify-category-api-graphql-transformers-e2e-tests@8.1.0 - graphql-versioned-transformer@5.2.38 * Added Windows compatible translation of "hoist-cli" script (#543) * fix(graphql): handle begin and end vtl keywords in index name (#510) * fix(graphql): handle begin and end vtl keywords in index name * updated comments * chore: cleanup stale s3 buckets, and remove references to amplify-app which we no longer leverage in our test suite (#556) * feature: add support for default generation of query and gsi names for @index directive behind a feature flag * fix(amplify-graphql-auth-transformer, amplify-graphql-relational-transformer, amplify-graphql-transformer-core): support custom primary key with relational directives (#462) * fix(amplify-graphql-auth-transformer, amplify-graphql-relational-transformer, amplify-graphql-transformer-core): support custom primary key with relational directives * fix: fixed refactor incorrect hanlding for filter vs connection input names * fix: merge build errors * fix: merge caused unit test failures * fix: merge caused e2e failures * fix: merge caused e2e failures * addressing PR feedback * fix: corrected allowed fields for relational fields with custom PK and restricted auth * fix: fixed imports and e2e feature flag initialization * test(graphql): fix failing datastore modelgen tests (#575) * test(graphql): fix failing datastore modelgen tests * moved the amplify-app to e2e tests package Co-authored-by: Al Harris <91494052+alharris-at@users.noreply.github.com> Co-authored-by: amplify-data-ci <amplify-data-dev+github@amazon.com> Co-authored-by: naedx <1711099+naedx@users.noreply.github.com> Co-authored-by: Alexander Harris <alharris@amazon.com> Co-authored-by: Pavel Lazar <85319655+lazpavel@users.noreply.github.com> * chore(release): Publish [ci skip] - @aws-amplify/amplify-category-api@3.1.2 - amplify-category-api-e2e-core@4.0.2 - amplify-category-api-e2e-tests@3.10.2 - @aws-amplify/graphql-auth-transformer@0.11.1 - @aws-amplify/graphql-default-value-transformer@0.5.28 - @aws-amplify/graphql-function-transformer@0.7.22 - @aws-amplify/graphql-http-transformer@0.8.22 - @aws-amplify/graphql-index-transformer@0.12.1 - @aws-amplify/graphql-maps-to-transformer@1.1.20 - amplify-category-api-graphql-migration-tests@2.3.2 - @aws-amplify/graphql-model-transformer@0.14.6 - @aws-amplify/graphql-predictions-transformer@0.6.22 - @aws-amplify/graphql-relational-transformer@0.10.1 - @aws-amplify/graphql-schema-test-library@1.1.1 - @aws-amplify/graphql-searchable-transformer@0.14.6 - @aws-amplify/graphql-transformer-core@0.17.6 - @aws-amplify/graphql-transformer-migrator@1.4.1 - amplify-category-api-migration-tests@5.0.2 - amplify-category-api-util-mock@5.1.1 - graphql-auth-transformer@7.2.39 - graphql-connection-transformer@5.2.39 - graphql-dynamodb-transformer@7.2.39 - graphql-elasticsearch-transformer@5.2.39 - graphql-function-transformer@3.3.30 - graphql-http-transformer@5.2.39 - graphql-key-transformer@3.2.39 - graphql-predictions-transformer@3.2.39 - graphql-relational-schema-transformer@2.21.9 - graphql-transformer-common@4.23.3 - graphql-transformer-core@7.6.2 - amplify-category-api-graphql-transformers-e2e-tests@8.1.1 - graphql-versioned-transformer@5.2.39 * fix conflict * fix conflict Co-authored-by: Al Harris <91494052+alharris-at@users.noreply.github.com> Co-authored-by: amplify-data-ci <amplify-data-dev+github@amazon.com> Co-authored-by: Christopher Sundersingh <83315412+sundersc@users.noreply.github.com> Co-authored-by: naedx <1711099+naedx@users.noreply.github.com> Co-authored-by: Alexander Harris <alharris@amazon.com> Co-authored-by: Pavel Lazar <85319655+lazpavel@users.noreply.github.com> * Update linting rules * Added Windows compatible translation of "hoist-cli" script (#543) * chore: cleanup stale s3 buckets, and remove references to amplify-app which we no longer leverage in our test suite (#556) * Feat: Single Source Read This adds the capability for but does not enable single source reading on GraphQL schemas This is intended for GraphQL Transformer V2 without support for V1 This also required pulling apart some of the logic in schema transformation so I can actually instantiate the transformer elsewhere * Nit: early return statement for ease of reading * Consolidate if statements * chore: merge release to main (#616) * chore: no-op change to trigger pipelines (#545) * chore(release): Publish [ci skip] - @aws-amplify/amplify-category-api@3.1.1 - amplify-category-api-dynamodb-simulator@2.4.1 - amplify-category-api-e2e-core@4.0.1 - amplify-category-api-e2e-tests@3.10.1 - @aws-amplify/graphql-auth-transformer@0.11.0 - @aws-amplify/graphql-default-value-transformer@0.5.27 - @aws-amplify/graphql-function-transformer@0.7.21 - @aws-amplify/graphql-http-transformer@0.8.21 - @aws-amplify/graphql-index-transformer@0.12.0 - @aws-amplify/graphql-maps-to-transformer@1.1.19 - amplify-category-api-graphql-migration-tests@2.3.1 - @aws-amplify/graphql-model-transformer@0.14.5 - @aws-amplify/graphql-predictions-transformer@0.6.21 - @aws-amplify/graphql-relational-transformer@0.10.0 - @aws-amplify/graphql-schema-test-library@1.1.0 - @aws-amplify/graphql-searchable-transformer@0.14.5 - @aws-amplify/graphql-transformer-core@0.17.5 - @aws-amplify/graphql-transformer-interfaces@1.14.4 - @aws-amplify/graphql-transformer-migrator@1.4.0 - amplify-category-api-migration-tests@5.0.1 - amplify-category-api-util-mock@5.1.0 - graphql-auth-transformer@7.2.38 - graphql-connection-transformer@5.2.38 - graphql-dynamodb-transformer@7.2.38 - graphql-elasticsearch-transformer@5.2.38 - graphql-function-transformer@3.3.29 - graphql-http-transformer@5.2.38 - graphql-key-transformer@3.2.38 - graphql-predictions-transformer@3.2.38 - graphql-transformer-core@7.6.1 - amplify-category-api-graphql-transformers-e2e-tests@8.1.0 - graphql-versioned-transformer@5.2.38 * API Category Release (#587) * chore: no-op change to trigger pipelines (#545) * chore(release): Publish [ci skip] - @aws-amplify/amplify-category-api@3.1.1 - amplify-category-api-dynamodb-simulator@2.4.1 - amplify-category-api-e2e-core@4.0.1 - amplify-category-api-e2e-tests@3.10.1 - @aws-amplify/graphql-auth-transformer@0.11.0 - @aws-amplify/graphql-default-value-transformer@0.5.27 - @aws-amplify/graphql-function-transformer@0.7.21 - @aws-amplify/graphql-http-transformer@0.8.21 - @aws-amplify/graphql-index-transformer@0.12.0 - @aws-amplify/graphql-maps-to-transformer@1.1.19 - amplify-category-api-graphql-migration-tests@2.3.1 - @aws-amplify/graphql-model-transformer@0.14.5 - @aws-amplify/graphql-predictions-transformer@0.6.21 - @aws-amplify/graphql-relational-transformer@0.10.0 - @aws-amplify/graphql-schema-test-library@1.1.0 - @aws-amplify/graphql-searchable-transformer@0.14.5 - @aws-amplify/graphql-transformer-core@0.17.5 - @aws-amplify/graphql-transformer-interfaces@1.14.4 - @aws-amplify/graphql-transformer-migrator@1.4.0 - amplify-category-api-migration-tests@5.0.1 - amplify-category-api-util-mock@5.1.0 - graphql-auth-transformer@7.2.38 - graphql-connection-transformer@5.2.38 - graphql-dynamodb-transformer@7.2.38 - graphql-elasticsearch-transformer@5.2.38 - graphql-function-transformer@3.3.29 - graphql-http-transformer@5.2.38 - graphql-key-transformer@3.2.38 - graphql-predictions-transformer@3.2.38 - graphql-transformer-core@7.6.1 - amplify-category-api-graphql-transformers-e2e-tests@8.1.0 - graphql-versioned-transformer@5.2.38 * Added Windows compatible translation of "hoist-cli" script (#543) * fix(graphql): handle begin and end vtl keywords in index name (#510) * fix(graphql): handle begin and end vtl keywords in index name * updated comments * chore: cleanup stale s3 buckets, and remove references to amplify-app which we no longer leverage in our test suite (#556) * feature: add support for default generation of query and gsi names for @index directive behind a feature flag * fix(amplify-graphql-auth-transformer, amplify-graphql-relational-transformer, amplify-graphql-transformer-core): support custom primary key with relational directives (#462) * fix(amplify-graphql-auth-transformer, amplify-graphql-relational-transformer, amplify-graphql-transformer-core): support custom primary key with relational directives * fix: fixed refactor incorrect hanlding for filter vs connection input names * fix: merge build errors * fix: merge caused unit test failures * fix: merge caused e2e failures * fix: merge caused e2e failures * addressing PR feedback * fix: corrected allowed fields for relational fields with custom PK and restricted auth * fix: fixed imports and e2e feature flag initialization * test(graphql): fix failing datastore modelgen tests (#575) * test(graphql): fix failing datastore modelgen tests * moved the amplify-app to e2e tests package Co-authored-by: Al Harris <91494052+alharris-at@users.noreply.github.com> Co-authored-by: amplify-data-ci <amplify-data-dev+github@amazon.com> Co-authored-by: naedx <1711099+naedx@users.noreply.github.com> Co-authored-by: Alexander Harris <alharris@amazon.com> Co-authored-by: Pavel Lazar <85319655+lazpavel@users.noreply.github.com> * chore(release): Publish [ci skip] - @aws-amplify/amplify-category-api@3.1.2 - amplify-category-api-e2e-core@4.0.2 - amplify-category-api-e2e-tests@3.10.2 - @aws-amplify/graphql-auth-transformer@0.11.1 - @aws-amplify/graphql-default-value-transformer@0.5.28 - @aws-amplify/graphql-function-transformer@0.7.22 - @aws-amplify/graphql-http-transformer@0.8.22 - @aws-amplify/graphql-index-transformer@0.12.1 - @aws-amplify/graphql-maps-to-transformer@1.1.20 - amplify-category-api-graphql-migration-tests@2.3.2 - @aws-amplify/graphql-model-transformer@0.14.6 - @aws-amplify/graphql-predictions-transformer@0.6.22 - @aws-amplify/graphql-relational-transformer@0.10.1 - @aws-amplify/graphql-schema-test-library@1.1.1 - @aws-amplify/graphql-searchable-transformer@0.14.6 - @aws-amplify/graphql-transformer-core@0.17.6 - @aws-amplify/graphql-transformer-migrator@1.4.1 - amplify-category-api-migration-tests@5.0.2 - amplify-category-api-util-mock@5.1.1 - graphql-auth-transformer@7.2.39 - graphql-connection-transformer@5.2.39 - graphql-dynamodb-transformer@7.2.39 - graphql-elasticsearch-transformer@5.2.39 - graphql-function-transformer@3.3.30 - graphql-http-transformer@5.2.39 - graphql-key-transformer@3.2.39 - graphql-predictions-transformer@3.2.39 - graphql-relational-schema-transformer@2.21.9 - graphql-transformer-common@4.23.3 - graphql-transformer-core@7.6.2 - amplify-category-api-graphql-transformers-e2e-tests@8.1.1 - graphql-versioned-transformer@5.2.39 * fix conflict * fix conflict Co-authored-by: Al Harris <91494052+alharris-at@users.noreply.github.com> Co-authored-by: amplify-data-ci <amplify-data-dev+github@amazon.com> Co-authored-by: Christopher Sundersingh <83315412+sundersc@users.noreply.github.com> Co-authored-by: naedx <1711099+naedx@users.noreply.github.com> Co-authored-by: Alexander Harris <alharris@amazon.com> Co-authored-by: Pavel Lazar <85319655+lazpavel@users.noreply.github.com> * Added Windows compatible translation of "hoist-cli" script (#543) * chore: cleanup stale s3 buckets, and remove references to amplify-app which we no longer leverage in our test suite (#556) * Feat: Single Source Read This adds the capability for but does not enable single source reading on GraphQL schemas This is intended for GraphQL Transformer V2 without support for V1 This also required pulling apart some of the logic in schema transformation so I can actually instantiate the transformer elsewhere * Nit: early return statement for ease of reading * Consolidate if statements * Nits: fixing some code quality requests * Add explicit error for no schema found Co-authored-by: Al Harris <91494052+alharris-at@users.noreply.github.com> Co-authored-by: amplify-data-ci <amplify-data-dev+github@amazon.com> Co-authored-by: naedx <1711099+naedx@users.noreply.github.com> Co-authored-by: Christopher Sundersingh <83315412+sundersc@users.noreply.github.com> Co-authored-by: Alexander Harris <alharris@amazon.com> Co-authored-by: Pavel Lazar <85319655+lazpavel@users.noreply.github.com> Co-authored-by: Zeyu Li <lizeyu@amazon.com>
|
This pull request introduces 7 alerts and fixes 1 when merging ad0cf6c into 9caf818 - view on LGTM.com new alerts:
fixed alerts:
|
alharris-at
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Release API Category
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.