fix: apply override unformity to root-stack

aws-amplify · Nov 5, 2021 · 001f039 · 001f039
1 parent 01b3ee1
commit 001f039
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/packages/amplify-provider-awscloudformation/resources/overrides-resource/override.ts b/packages/amplify-provider-awscloudformation/resources/overrides-resource/override.ts
@@ -1,5 +1,3 @@
 import { AmplifyRootStackTemplate } from '@aws-amplify/cli-overrides-helper';
 
-export function overrideProps(props: AmplifyRootStackTemplate) {
-  return props;
-}
+export function override(resources: AmplifyRootStackTemplate) {}
diff --git a/packages/amplify-provider-awscloudformation/resources/overrides-resource/package.json b/packages/amplify-provider-awscloudformation/resources/overrides-resource/package.json
@@ -1,5 +1,5 @@
 {
-    "name": "overrides-for-root-stack",
+    "name": "overrides-dependencies",
     "version": "1.0.0",
     "description": "",
     "scripts": {
@@ -8,8 +8,6 @@
       "test": "echo \"Error: no test specified\" && exit 1"
     },
     "dependencies": {
-      "@types/fs-extra": "^9.0.11",
-      "fs-extra": "^9.1.0",
       "@aws-amplify/cli-overrides-helper": "1.1.0-ext11.0"
     },
     "devDependencies": {

diff --git a/packages/amplify-provider-awscloudformation/src/root-stack-builder/root-stack-transform.ts b/packages/amplify-provider-awscloudformation/src/root-stack-builder/root-stack-transform.ts
@@ -60,14 +60,13 @@ export class AmplifyRootStackTransform {
         amplifyPrinter.formatter.list(['No override File Found', `To override ${this._resourceName} run amplify override auth`]);
         return '';
       });
-      const rootStackTemplateObj = this._rootTemplateObj as AmplifyRootStackTemplate;
       const sandboxNode = new vm.NodeVM({
         console: 'inherit',
         timeout: 5000,
         sandbox: {},
       });
       try {
-        this._rootTemplateObj = sandboxNode.run(overrideCode).overrideProps(rootStackTemplateObj);
+        sandboxNode.run(overrideCode).overrideProps(this._rootTemplateObj);
       } catch (err: $TSAny) {
         const error = new Error(`Skipping override due to ${err}${os.EOL}`);
         printer.error(`${error}`);