Skip to content

Commit

Permalink
fix: address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
akshbhu committed Nov 7, 2021
1 parent 49abc16 commit 019bb16
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 39 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"test": "echo \"Error: no test specified\" && exit 1"
},
"dependencies": {
"@aws-amplify/cli-extensibility-helper": "1.1.0-ext11.0"
"@aws-amplify/cli-extensibility-helper": "1.1.0-ext15.0"
},
"devDependencies": {
"typescript": "^4.2.4"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"test": "echo \"Error: no test specified\" && exit 1"
},
"dependencies": {
"@aws-amplify/cli-extensibility-helper": "1.1.0-ext11.0"
"@aws-amplify/cli-extensibility-helper": "1.1.0-ext15.0"

},
"devDependencies": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"test": "echo \"Error: no test specified\" && exit 1"
},
"dependencies": {
"@aws-amplify/cli-extensibility-helper": "1.1.0-ext11.0"
"@aws-amplify/cli-extensibility-helper": "1.1.0-ext15.0"
},
"devDependencies": {
"typescript": "^4.2.4"
Expand Down
10 changes: 1 addition & 9 deletions packages/amplify-category-storage/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,7 @@ import {
headlessRemoveStorage,
headlessUpdateStorage,
} from './provider-utils/awscloudformation/storage-configuration-helpers';
export { AmplifyDDBResourceTemplate, AmplifyS3ResourceTemplate } from '@aws-amplify/cli-extensibility-helper';
export { categoryName as category } from './constants';
export { AmplifyDDBResourceTemplate, AmplifyS3ResourceTemplate } from './provider-utils/awscloudformation/cdk-stack-builder/types';
import { getAllDefaults } from './provider-utils/awscloudformation/default-values/s3-defaults';
import {
S3AccessType,
S3PermissionType,
S3UserInputs,
} from './provider-utils/awscloudformation/service-walkthrough-types/s3-user-input-types';
export {
S3UserInputs,
S3UserInputTriggerFunctionParams,
Expand All @@ -44,9 +36,9 @@ export {
s3CreateStorageResource,
s3GetResourceName,
s3GetUserInput,
s3RegisterAdminTrigger,
s3RemoveAdminLambdaTrigger,
s3RemoveStorageLambdaTrigger,
s3RegisterAdminTrigger,
} from './provider-utils/awscloudformation/service-walkthroughs/s3-resource-api';

export async function s3GetBucketUserInputDefault(project: $TSAny, shortId: string, accessType: S3AccessType): Promise<S3UserInputs> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"test": "echo \"Error: no test specified\" && exit 1"
},
"dependencies": {
"@aws-amplify/cli-extensibility-helper": "1.1.0-ext11.0"
"@aws-amplify/cli-extensibility-helper": "1.1.0-ext15.0"
},
"devDependencies": {
"typescript": "^4.2.4"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
import { AmplifyRootStackTemplate } from '@aws-amplify/cli-extensibility-helper';
import { $TSContext, CFNTemplateFormat, Template, pathManager, writeCFNTemplate, buildOverrideDir, $TSAny } from 'amplify-cli-core';
import { AmplifyRootStack, AmplifyRootStackOutputs } from './root-stack-builder';
import { RootStackSythesizer } from './stack-synthesizer';
import { App } from '@aws-cdk/core';
import * as cdk from '@aws-cdk/core';
import * as path from 'path';
import { App } from '@aws-cdk/core';
import { $TSAny, $TSContext, buildOverrideDir, CFNTemplateFormat, pathManager, Template, writeCFNTemplate } from 'amplify-cli-core';
import * as amplifyPrinter from 'amplify-prompts';
import { printer } from 'amplify-prompts';
import * as fs from 'fs-extra';
import os from 'os';
import * as path from 'path';
import * as vm from 'vm2';
import { printer } from 'amplify-prompts';
import { AmplifyRootStack, AmplifyRootStackOutputs } from './root-stack-builder';
import { RootStackSythesizer } from './stack-synthesizer';

export class AmplifyRootStackTransform {
private app: App | undefined;
Expand Down

0 comments on commit 019bb16

Please sign in to comment.