fix: function e2e tests (#7295)

Fixes function e2e test bugs
aws-amplify · May 8, 2021 · 5c918be · 5c918be
1 parent 673aaa7
commit 5c918be
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/...-function/src/provider-utils/awscloudformation/service-walkthroughs/lambda-walkthrough.ts b/...-function/src/provider-utils/awscloudformation/service-walkthroughs/lambda-walkthrough.ts
@@ -197,9 +197,6 @@ export async function updateWalkthrough(context, lambdaToUpdate?: string) {
     merge(functionParameters, additionalParameters);
 
     updateCFNFileForResourcePermissions(resourceDirPath, functionParameters, currentParameters);
-  } else {
-    // Need to load previous dependsOn
-    functionParameters.dependsOn = _.get(context.amplify.getProjectMeta(), ['function', lambdaToUpdate, 'dependsOn'], []);
   }
 
   // ask scheduling Lambda questions and merge in results
@@ -353,7 +350,7 @@ export function updateCFNFileForResourcePermissions(
     apiResourceName,
   );
 
-  if (cfnContent.Resources.AmplifyResourcesPolicy > 0) {
+  if (!cfnContent.Resources.AmplifyResourcesPolicy) {
     cfnContent.Resources.AmplifyResourcesPolicy = {
       DependsOn: ['LambdaExecutionRole'],
       Type: 'AWS::IAM::Policy',
@@ -366,12 +363,15 @@ export function updateCFNFileForResourcePermissions(
         ],
         PolicyDocument: {
           Version: '2012-10-17',
-          Statement: functionParameters.categoryPolicies,
+          Statement: [],
         },
       },
     };
-  } else {
+  }
+  if (functionParameters.categoryPolicies.length === 0) {
     delete cfnContent.Resources.AmplifyResourcesPolicy;
+  } else {
+    cfnContent.Resources.AmplifyResourcesPolicy.Properties.PolicyDocument.Statement = functionParameters.categoryPolicies;
   }
 
   cfnContent.Resources.LambdaFunction.Properties.Environment.Variables = getNewCFNEnvVariables(