fix: ensure REST API CFN outputs the API ID #7538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the REST API migration logic to ensure that the API ID is a CFN Output, as the policy consolidation logic will rely on this during push.
ammarkarachi
approved these changes
Jun 17, 2021
attilah
reviewed
Jun 17, 2021
packages/amplify-provider-awscloudformation/src/utils/consolidate-apigw-policies.ts
Outdated
Show resolved
Hide resolved
attilah
approved these changes
Jun 17, 2021
|
👋 Hi, this pull request was referenced in the v5.0.1 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.0.1. |
github-actions
bot
added
the
referenced-in-release
3 tasks
edwardfoyle
pushed a commit
that referenced
this pull request
Jun 24, 2021
cjihrig
added a commit
to ctjlewis/amplify-cli
that referenced
this pull request
Jul 12, 2021
* fix: ensure REST API CFN outputs the API ID This commit updates the REST API migration logic to ensure that the API ID is a CFN Output, as the policy consolidation logic will rely on this during push. * fix: replace early return with throw Co-authored-by: Colin Ihrig <colihrig@amazon.com>
cjihrig
added a commit
to ctjlewis/amplify-cli
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit updates the REST API migration logic to ensure that the API ID is a CFN Output, as the policy consolidation logic will rely on this during push.
Issue #, if available
Description of how you validated changes
Manual testing
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.