chore: add regression test for #7538 #7563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cfnTemplate.Outputs.ApiId = undefined; | ||
|
|
||
| writeFileSync(cfnTemplateFile, JSON.stringify(cfnTemplate)); | ||
| await amplifyPushUpdate(projRoot); |
There was a problem hiding this comment.
Does this only happen for the output? or do we generate the full Cfn again?
There was a problem hiding this comment.
The full CFN is not regenerated, just the ApiId output is added.
ammarkarachi
approved these changes
Jun 21, 2021
This commit adds a regression test for the case where a REST API is pushed without an ApiId output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit adds a regression test for the case where a REST API is pushed without an ApiId output.
Issue #, if available
This is a regression test for #7538
Description of how you validated changes
The test in this PR.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.