Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn test on master fails in amplify-appsync-simulator #9703

Closed
5 tasks done
gpoul opened this issue Feb 4, 2022 · 1 comment · Fixed by #9706
Closed
5 tasks done

Yarn test on master fails in amplify-appsync-simulator #9703

gpoul opened this issue Feb 4, 2022 · 1 comment · Fixed by #9706
Assignees
@cjihrig
Labels
bug Something isn't working mock Issues tied to the mock functionality

Comments

@gpoul
Copy link

gpoul commented Feb 4, 2022

Before opening, please confirm:

  • I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
  • I have searched for duplicate or closed issues.
  • I have read the guide for submitting bug reports.
  • I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
  • I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?

git clone the source

If applicable, what version of Node.js are you using?

v16.13.1

Amplify CLI Version

master

What operating system are you using?

Amazon Linux 2

Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.

None

Amplify Categories

api

Amplify Commands

Not applicable

Describe the bug

yarn test fails with "AWSURL parse Should reject an invalid URL 1" in the tests within amplify-appsync-simulator:

image

Expected behavior

yarn test should complete successfully

Reproduction steps

  1. Perform local env setup as described in https://github.com/aws-amplify/amplify-cli/blob/master/CONTRIBUTING.md#local-environment-setup
  2. Run yarn setup-dev
  3. Run yarn test

GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information

No response
@cjihrig
Copy link
Contributor

cjihrig commented Feb 4, 2022

I am able to reproduce this with Node 16. The tests do not fail on Node 14, which explains how the change made it past our CI. Marking as a bug.

@cjihrig cjihrig added bug Something isn't working mock Issues tied to the mock functionality labels Feb 4, 2022
@cjihrig cjihrig self-assigned this Feb 4, 2022
@cjihrig cjihrig mentioned this issue Feb 4, 2022
Merged
ammarkarachi pushed a commit that referenced this issue Feb 4, 2022
@cjihrig @cjihrig-aws
test: fix failing AWSURL unit tests on Node 16 (#9706)
5d053e1 
The message shown on ERR_INVALID_URL errors changed slightly in
Node 16. This commit updates two AWSURL unit tests to pass across
supported Node.js versions.

Fixes: #9703

Co-authored-by: Colin Ihrig <colihrig@amazon.com>
d10-cc pushed a commit to d10-cc/amplify-appsync-simulator that referenced this issue Jan 6, 2023
@cjihrig @cjihrig-aws
test: fix failing AWSURL unit tests on Node 16 (#9706)
2f3adc4 
The message shown on ERR_INVALID_URL errors changed slightly in
Node 16. This commit updates two AWSURL unit tests to pass across
supported Node.js versions.

Fixes: aws-amplify/amplify-cli#9703

Co-authored-by: Colin Ihrig <colihrig@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjihrig cjihrig

Labels
bug Something isn't working mock Issues tied to the mock functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix failing AWSURL unit tests on Node 16
2 participants
@gpoul @cjihrig