fix: validate that the app limit has not been reached (issue #10063) #10158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate that the app limit has not been reached by checking the meta file and print a warning it it has been reached Closes aws-amplify#10063
Codecov Report
@@ Coverage Diff @@
## master #10158 +/- ##
==========================================
+ Coverage 54.08% 54.17% +0.08%
==========================================
Files 837 840 +3
Lines 46340 46420 +80
Branches 9885 9897 +12
==========================================
+ Hits 25065 25150 +85
+ Misses 19281 19272 -9
- Partials 1994 1998 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jhockett
reviewed
Apr 7, 2022
There was a problem hiding this comment.
Thanks for the contribution @SebasRod23. One minor comment, but otherwise LGTM pending the API review outcome.
| const appId = currentAmplifyMeta?.providers?.awscloudformation?.AmplifyAppId; | ||
|
|
||
| if (!appId) { | ||
| printer.warn('You have reached your app limit:'); |
There was a problem hiding this comment.
Should this be Amplify App limit
|
This PR will be merged after API Review |
renebrandel
reviewed
May 4, 2022
| const appId = currentAmplifyMeta?.providers?.awscloudformation?.AmplifyAppId; | ||
|
|
||
| if (!appId) { | ||
| printer.warn('You have reached your Amplify App limit:'); |
There was a problem hiding this comment.
The maximum number of apps that you can create with Amplify in this region has likely been reached:
For more information on Amplify Service Quotas, see:
https://docs.aws.amazon.com/general/latest/gr/amplify.html#service-quotas-amplify
jhockett
approved these changes
May 5, 2022
akshbhu
approved these changes
May 5, 2022
akshbhu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Validate that the app limit has not been reached by checking the meta file and print a warning it it
has been reached
Issue #, if available
Closes #10063
Description of how you validated changes
Reached the app limit and got the expected warning. Then, deleted an app in the cloud and created a new project, the warning was not printed as expected.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.