Revert "feat: add handling of colon-delimited identity claims to query" #10213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielleadams
requested review from
a team,
marcvberg,
phani-srikar,
sundersc and
alharris-at
as code owners
lazpavel
approved these changes
Apr 14, 2022
akshbhu
approved these changes
Apr 14, 2022
danielleadams
added a commit
to danielleadams/amplify-cli
that referenced
this pull request
Apr 23, 2022
… to query (aws-amplify#10189)" (aws-amplify#10213)" This reverts commit 9f13064.
danielleadams
added a commit
that referenced
this pull request
Apr 28, 2022
…t) (#10222) * Revert "Revert "feat: add handling of colon-delimited identity claims to query (#10189)" (#10213)" This reverts commit 9f13064. * feat: put field resolver behind feature flag * fix: add feature flag to tests * fix: use resolver helper for field * fix: update query requests with double delimiter * test: update snapshots for unit tests * test: add feature flag to mock e2e test * fix: fix primary and index key in auth * fix: add claim matching for passed in list params * fix: change field map to use claim and update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10189