Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: matches identity claim for subscription (revert) #10277

Merged

Conversation

danielleadams
Copy link
Contributor

@danielleadams danielleadams commented Apr 23, 2022

Reverts #10264
Re-reverts #10199

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2022

Codecov Report

Merging #10277 (b334f3a) into master (fd2e4ff) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10277      +/-   ##
==========================================
+ Coverage   54.35%   54.37%   +0.02%     
==========================================
  Files         851      851              
  Lines       46974    46974              
  Branches    10011    10011              
==========================================
+ Hits        25532    25542      +10     
+ Misses      19427    19418       -9     
+ Partials     2015     2014       -1     
Impacted Files Coverage Δ
...ql-auth-transformer/src/resolvers/subscriptions.ts 100.00% <ø> (ø)
...-graphql-auth-transformer/src/resolvers/helpers.ts 86.30% <0.00%> (+13.69%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@danielleadams danielleadams force-pushed the revert-10264-revert-10199-ic-changes-subscription branch from f6ce206 to af32988 Compare April 26, 2022 19:05
@danielleadams danielleadams changed the title Revert "Revert "refactor: use a prefix matching for the claim in subscriptions"" matches identity claim for subscription Apr 26, 2022
@danielleadams danielleadams changed the title matches identity claim for subscription feat: matches identity claim for subscription Apr 26, 2022
@danielleadams danielleadams changed the title feat: matches identity claim for subscription feat: matches identity claim for subscription (revert) Apr 26, 2022
@danielleadams danielleadams merged commit baf9908 into master Apr 27, 2022
@danielleadams danielleadams deleted the revert-10264-revert-10199-ic-changes-subscription branch June 9, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants