fix: prevent symlinks on nodejs package install #10293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpc
approved these changes
Apr 28, 2022
sachscode
approved these changes
Apr 28, 2022
sachscode
pushed a commit
to sachscode/amplify-cli
that referenced
this pull request
May 4, 2022
akshbhu
pushed a commit
that referenced
this pull request
May 5, 2022
…ands (#10288) * (chore) added flow report class * (feat) amplify cli flow journaling * (chore) insert unique project identifier to index logs * (chore) add timestamp to interactions for Dx tracking * feat: walkthrough logging for headless apis * chore: upgrade lodash dependencies * (chore) flow-report headless unit-tests and redactions * chore: fix unit tests broken by flow * chore: remove extraneous debug logs * chore: update unit tests for redactions and interactive flows * chore: remove extraneous lib folder and update gitignore * chore: address-pr-comment: remove input params from no-op functions * chore: PR comments make flowData as member of usageData instead of singleton * chore: PR comment - revert change which made line too long to read * chore: PR comment - remove extraneous calls to pushFlow and remove pushHeadlessFlow from prompter * chore: PR comment - changelog will be added only after the release * chore: fix lgtm bot errors * fix: ignore amplify-cli-shared-interfaces for testing * fix: prevent symlinks on nodejs package install (#10293) * fix auth unit-tests breaking because of headless flow logging * chore: redact hidden inputs * fix : mocking errors in usageData instance Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> Co-authored-by: John Hockett <jhockett@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add
--no-bin-linksflag to both yarn and npm install commands to prevent packaging issues for nodejsDescription of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.