fix: back off on cfn event pull #11624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sobolk
commented
Dec 19, 2022
| @@ -1306,7 +1306,7 @@ commands: | |||
| source $BASH_ENV | |||
| amplify version | |||
| retry runE2eTest | |||
| no_output_timeout: 60m | |||
| no_output_timeout: 90m | |||
There was a problem hiding this comment.
It has to go up until searchable migration is faster.
Comment on lines
157
to
170
| const self = this; | ||
| let delay = CFN_POLL_TIME; | ||
| let readStackEventsCalls = 0; | ||
| let invoker = function() { | ||
| self.addToPollQueue(stackName, 3); | ||
| if (delay < CFN_POLL_TIME_MAX) { | ||
| delay = Math.min(Math.pow(2, readStackEventsCalls) * CFN_POLL_TIME, CFN_POLL_TIME_MAX); | ||
| } | ||
| self.pollForEvents = setTimeout(invoker, delay); | ||
| readStackEventsCalls++; | ||
| } | ||
|
|
||
| // start it off | ||
| self.pollForEvents = setTimeout(invoker, delay); |
There was a problem hiding this comment.
| @@ -153,7 +154,20 @@ class CloudFormation { | |||
| } | |||
|
|
|||
| readStackEvents(stackName) { | |||
| this.pollForEvents = setInterval(() => this.addToPollQueue(stackName, 3), CFN_POLL_TIME); | |||
| const self = this; | |||
There was a problem hiding this comment.
Do we need this rename?
sdstolworthy
previously approved these changes
Dec 19, 2022
jhockett
previously approved these changes
Dec 19, 2022
packages/amplify-provider-awscloudformation/src/aws-utils/aws-cfn.js
Outdated
Show resolved
Hide resolved
jhockett
approved these changes
Dec 19, 2022
sdstolworthy
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
I injected
console.log('Delay ' + delay + ' Attempt ' + readStackEventsCalls);intoreadStackEventsand ran one of the e2e tests. Below is outcome.E2E test run.
https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/13698/workflows/634b1e55-3c58-49fe-b88e-db161cafb298
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.