Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amplify-provider-awscloudformation): custom transformer imports #3236

Merged
merged 5 commits into from
May 6, 2020
Merged

fix(amplify-provider-awscloudformation): custom transformer imports #3236

merged 5 commits into from
May 6, 2020

Commits on May 4, 2020

  1. fix(amplify-provider-awscloudformation): custom transformer imports 

    Current implementation misuses createRequireFromPath API.
Unfortunately this API doesn't support directory path well.

For example,

```
createRequireFromPath("/my/project")("./node_modules/mylib")
```

isn't same as

```
require("/my/project/node_modules/mylib")
```

Actually, it's

```
require("/my/node_modules/mylib")
```
    @hirochachacha @attilah
    hirochachacha authored and attilah committed May 4, 2020
    Configuration menu
    Copy the full SHA
    e1621a8 View commit details
    Browse the repository at this point in the history

  2. fix: transformer loading to use existing packages and use global prefix

    @attilah
    attilah committed May 4, 2020
    Configuration menu
    Copy the full SHA
    2053463 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Merge branch 'master' into fix/custom_transformer_imports

    Attila Hajdrik authored May 6, 2020
    Configuration menu
    Copy the full SHA
    68d9873 View commit details
    Browse the repository at this point in the history

  2. fix: update yarn.lock

    @attilah
    attilah committed May 6, 2020
    Configuration menu
    Copy the full SHA
    2149a09 View commit details
    Browse the repository at this point in the history

  3. fix: test failures for subscription after yarn.lock update

    @attilah
    attilah committed May 6, 2020
    Configuration menu
    Copy the full SHA
    5db5e97 View commit details
    Browse the repository at this point in the history