fix(graphql-auth-transformer): add a time delay when creating apiKey #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a time delay to the expiration date re aws-amplify#4460
Codecov Report
@@ Coverage Diff @@
## master #4493 +/- ##
==========================================
+ Coverage 60.76% 60.86% +0.09%
==========================================
Files 335 334 -1
Lines 14740 14718 -22
Branches 2953 2784 -169
==========================================
+ Hits 8957 8958 +1
Misses 5337 5337
+ Partials 446 423 -23
Continue to review full report at Codecov.
|
attilah
suggested changes
Jun 8, 2020
add expiration delay time for 1 day
jhockett
reviewed
Jul 7, 2020
SwaySway
force-pushed
the
i4460
branch
2 times, most recently
from
6cc52c6 to
0989513
Compare
attilah
approved these changes
Jul 14, 2020
filter number in askApiKeyQuestions, edit e2e to 1 day for apikey, and add delay if its one day in @auth
nikhname
pushed a commit
to nikhname/amplify-cli
that referenced
this pull request
Jul 27, 2020
sebastiancrossa
pushed a commit
to MLH-Fellowship/amplify-cli
that referenced
this pull request
Aug 4, 2020
sebastiancrossa
pushed a commit
to MLH-Fellowship/amplify-cli
that referenced
this pull request
Aug 25, 2020
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a time delay to the expiration date
re #4460
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.