Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql-auth-transformer): allow auth progation to recursive types #4788

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

SwaySway
Copy link
Contributor

@SwaySway SwaySway commented Jul 9, 2020

allow auth progation to recursive types - once auth has been added to a non model type it will not
re-add auth to said type

re #4631

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit but LGTM

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #4788 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4788      +/-   ##
==========================================
+ Coverage   60.49%   60.51%   +0.01%     
==========================================
  Files         350      350              
  Lines       15192    15198       +6     
  Branches     3040     3044       +4     
==========================================
+ Hits         9191     9197       +6     
  Misses       5496     5496              
  Partials      505      505              
Impacted Files Coverage Δ
...aphql-auth-transformer/src/ModelAuthTransformer.ts 88.03% <100.00%> (+0.06%) ⬆️
packages/graphql-auth-transformer/src/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c55e3...4ea5381. Read the comment docs.

allow auth progation to recursive types - once auth has been added to a non model type it will not
re-add auth to said type

re aws-amplify#4631
@SwaySway SwaySway merged commit 827c7b8 into aws-amplify:master Jul 14, 2020
nikhname pushed a commit to nikhname/amplify-cli that referenced this pull request Jul 27, 2020
aws-amplify#4788)

allow auth progation to recursive types - once auth has been added to a non model type it will not
re-add auth to said type

re aws-amplify#4631
sebastiancrossa pushed a commit to MLH-Fellowship/amplify-cli that referenced this pull request Aug 4, 2020
aws-amplify#4788)

allow auth progation to recursive types - once auth has been added to a non model type it will not
re-add auth to said type

re aws-amplify#4631
sebastiancrossa pushed a commit to MLH-Fellowship/amplify-cli that referenced this pull request Aug 25, 2020
aws-amplify#4788)

allow auth progation to recursive types - once auth has been added to a non model type it will not
re-add auth to said type

re aws-amplify#4631
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants