Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: headless update auth #5308

Merged
merged 4 commits into from
Sep 24, 2020

Conversation

edwardfoyle
Copy link
Contributor

Description of changes:
Add schema for update auth and wire it up to existing auth update logic

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #5308 into master will decrease coverage by 0.69%.
The diff coverage is 38.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5308      +/-   ##
==========================================
- Coverage   59.82%   59.12%   -0.70%     
==========================================
  Files         394      399       +5     
  Lines       17579    17968     +389     
  Branches     3307     3370      +63     
==========================================
+ Hits        10516    10623     +107     
- Misses       6449     6718     +269     
- Partials      614      627      +13     
Impacted Files Coverage Δ
...amplify-category-notifications/lib/channel-APNS.js 62.50% <0.00%> (-0.72%) ⬇️
packages/amplify-category-xr/commands/xr/push.js 30.00% <0.00%> (-3.34%) ⬇️
packages/amplify-category-xr/lib/xr-manager.js 13.13% <0.00%> (-0.10%) ⬇️
packages/amplify-util-mock/src/utils/git-ignore.ts 33.33% <0.00%> (ø)
...s/awscloudformation/utils/amplify-meta-updaters.ts 11.90% <13.63%> (ø)
...ls/awscloudformation/utils/synthesize-resources.ts 13.42% <18.66%> (-2.12%) ⬇️
...ls/awscloudformation/handlers/resource-handlers.ts 24.13% <24.13%> (ø)
.../awscloudformation/utils/auth-defaults-appliers.ts 33.33% <25.00%> (ø)
...r-utils/awscloudformation/utils/message-printer.ts 25.00% <25.00%> (ø)
...auth/src/provider-utils/awscloudformation/index.js 5.38% <30.76%> (+0.64%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ce4bc...f7be991. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Sep 11, 2020

This pull request introduces 3 alerts when merging a22ecae into 5a324b2 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 11, 2020

This pull request introduces 3 alerts when merging eba7bb5 into 8747911 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 11, 2020

This pull request introduces 3 alerts when merging 5e76ab0 into 42810c9 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

Copy link
Contributor

@kaustavghosh06 kaustavghosh06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2020

This pull request introduces 3 alerts when merging 4d3ad06 into 6cec107 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2020

This pull request introduces 3 alerts when merging 88feff0 into 0d2f632 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 24, 2020

This pull request introduces 3 alerts when merging f7be991 into 41ce4bc - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@edwardfoyle edwardfoyle merged commit b942f35 into aws-amplify:master Sep 24, 2020
r0zar pushed a commit to r0zar/amplify-cli that referenced this pull request Nov 19, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants