fix(amplify-velocity-template): expression not equals works improperly #5571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used with amplify-appsync-simulator the not equals (!=) expression doesn't work properly. Two strings are considered inequal when should be considered equals. fix aws-amplify#5570
Codecov Report
@@ Coverage Diff @@
## master #5571 +/- ##
==========================================
+ Coverage 59.08% 59.26% +0.17%
==========================================
Files 402 402
Lines 18043 18043
Branches 3575 3575
==========================================
+ Hits 10661 10693 +32
+ Misses 6723 6689 -34
- Partials 659 661 +2
Continue to review full report at Codecov.
|
yuth
approved these changes
Oct 14, 2020
r0zar
pushed a commit
to r0zar/amplify-cli
that referenced
this pull request
Nov 19, 2020
aws-amplify#5571) When used with amplify-appsync-simulator the not equals (!=) expression doesn't work properly. Two strings are considered inequal when should be considered equals. fix aws-amplify#5570 Co-authored-by: Fernando Chucre <fernando@oraoncology.com>
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with amplify-appsync-simulator the not equals (!=) expression doesn't work properly. Two
strings are considered inequal when should be considered equals.
fix #5570
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.