fix(amplify-app): initialize feature flag #5643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated amplify-app to initialize feature flags and part of init process
nikhname
reviewed
Oct 20, 2020
packages/amplify-app/src/index.js
Outdated
| @@ -105,7 +106,8 @@ async function createAmplifySkeletonProject() { | |||
| console.log(`${emoji.get('guitar')} Creating base Amplify project`); | |||
|
|
|||
| return new Promise((resolve, reject) => { | |||
| const createSkeletonAmplifyProject = spawn(amplify, ['init', '--quickstart'], { | |||
| const cmd = path.basename(process.argv[1]) === 'amplify-app-dev' ? amplifyDev : amplify; | |||
There was a problem hiding this comment.
Can we rename this to amplifyCmd for clarity?
nikhname
approved these changes
Oct 20, 2020
r0zar
pushed a commit
to r0zar/amplify-cli
that referenced
this pull request
Nov 19, 2020
Updated amplify-app to initialize feature flags and part of init process by updating CLIs `--bootstrap` command to run Feature Flag initialization
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated amplify-app to initialize feature flags and part of init process. Updated the Amplify App to load
amplify-devif theamplify-app-devcommand is used