fix(amplify-appsync-simulator): parse AWSTimestamp literals as Ints #6979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the AWSTimestamp custom scalar to return literals as integers instead of strings. The AST representation of a literal is always a string, so it needs to be converted to an int before returning it for further processing. Refs: #6436
Codecov Report
@@ Coverage Diff @@
## master #6979 +/- ##
=======================================
Coverage 56.41% 56.42%
=======================================
Files 445 445
Lines 21764 21766 +2
Branches 4354 4354
=======================================
+ Hits 12278 12281 +3
+ Misses 8671 8670 -1
Partials 815 815
Continue to review full report at Codecov.
|
yuth
approved these changes
Mar 29, 2021
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v4.48.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.48.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit updates the
AWSTimestampcustom scalar to return literals as integers instead of strings. The AST representation of a literal is always a string, so it needs to be converted to an int before returning it for further processing.Issue #, if available
#6436
Description of how you validated changes
Manual testing and unit tests added in this PR.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.