fix(amplify-e2e-core): update source of truth for supported regions #6988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6988 +/- ##
=======================================
Coverage 56.41% 56.41%
=======================================
Files 445 445
Lines 21764 21764
Branches 4354 4354
=======================================
Hits 12278 12278
Misses 8671 8671
Partials 815 815
Continue to review full report at Codecov.
|
This commit uses the region list exported from aws-regions.js in aws-utils/aws-amplify.js instead of duplicating the list.
yuth
reviewed
Mar 30, 2021
| 'ap-southeast-2', | ||
| 'ca-central-1', | ||
| ]; | ||
| const { regions: amplifyServiceRegions } = require('../aws-regions'); |
There was a problem hiding this comment.
Is this list identical to what we had?
There was a problem hiding this comment.
Yes, although not sorted in the same order. Here is where they come from.
yuth
approved these changes
Mar 30, 2021
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v4.48.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.48.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
#3992 added a list of supported regions in amplify-e2e-core. When #4092 was merged, it added a second list of supported regions, which has drifted from the other list. This commit consolidates the two lists.
Issue #, if available
Description of how you validated changes
Ran an e2e test locally.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.