fix: skip admin queries when consolidating REST APIs #7142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7142 +/- ##
==========================================
- Coverage 51.54% 51.53% -0.01%
==========================================
Files 486 486
Lines 25051 25053 +2
Branches 4913 4915 +2
==========================================
Hits 12912 12912
- Misses 11187 11189 +2
Partials 952 952
Continue to review full report at Codecov.
|
edwardfoyle
reviewed
Apr 20, 2021
| @@ -231,7 +235,7 @@ export function loadApiWithPrivacyParams(context: $TSContext, name: string, reso | |||
| } | |||
|
|
|||
| function updateExistingApiCfn(context: $TSContext, api: $TSObject): void { | |||
| const { resourceName } = api.params; | |||
| const resourceName = api.resourceName || api.params.resourceName; | |||
There was a problem hiding this comment.
should we have any defensive logic here to early return if resourceName is undefined?
edwardfoyle
approved these changes
Apr 20, 2021
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v4.50.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.50.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit skips over the admin queries REST API when consolidating the user's REST APIs.
Issue #, if available
Refs: #2084
Description of how you validated changes
Ran several failing E2E tests.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.