Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: profile validation to include source_profile and role_arn #7173

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

jhockett
Copy link
Contributor

Description of changes

fix incorrect validation introduced in #7017

Issue #, if available

Description of how you validated changes

Ran unit tests and successfully completed amplify init using an IAM role in a profile

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jhockett jhockett requested a review from a team as a code owner April 23, 2021 22:20
@edwardfoyle edwardfoyle merged commit 70a980f into aws-amplify:master Apr 23, 2021
@toelke
Copy link
Contributor

toelke commented Apr 24, 2021

Woah, fast work. Thanks!

@jhockett jhockett deleted the profile-validation-fix branch April 25, 2021 03:29
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Apr 27, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v4.50.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.50.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants