Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditionally rebuild container apis on push #7175

Merged
merged 1 commit into from
May 5, 2021
Merged

fix: conditionally rebuild container apis on push #7175

merged 1 commit into from
May 5, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 24, 2021

Description of changes

This commit adds logic to rebuild container based APIs during
push if necessary.

Issue #, if available

#6684

Description of how you validated changes

Follow the steps to reproduce in #6684.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cjihrig cjihrig requested a review from a team as a code owner April 24, 2021 14:20
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2021

Codecov Report

Merging #7175 (b571583) into master (ec1613e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7175      +/-   ##
==========================================
- Coverage   52.28%   52.28%   -0.01%     
==========================================
  Files         491      491              
  Lines       25242    25245       +3     
  Branches     4952     4953       +1     
==========================================
  Hits        13199    13199              
- Misses      11091    11094       +3     
  Partials      952      952              
Impacted Files Coverage Δ
...y-provider-awscloudformation/src/push-resources.ts 10.37% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec1613e...b571583. Read the comment docs.

This commit adds logic to rebuild container based APIs during
push if necessary.

Refs: #6684
@cjihrig cjihrig merged commit a27a033 into aws-amplify:master May 5, 2021
@cjihrig cjihrig deleted the bug branch May 5, 2021 14:51
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v4.51.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.51.0.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label May 14, 2021
cjihrig added a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
This commit adds logic to rebuild container based APIs during
push if necessary.

Refs: aws-amplify#6684

Co-authored-by: Colin Ihrig <colihrig@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to Fargate/Container-Based API Services Not Reflected After Purported Successful Redeployment
4 participants