fix: ensure policy resource name when pushing REST APIs #7192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that older REST APIs have never been updated to include the policyResourceName field on paths. This commit ensures that the field is present. Refs: #7190
When removing the auth and unauth roles from REST APIs, the CFN template and the parameters.json file should be processed separately in case they have gotten out of sync. Otherwise, the generated root stack is likely to have errors.
4 tasks
This commit moves the check for AdminQueries from consolidateApiGatewayPolicies() to loadApiWithPrivacyParams(), as the latter is also called from push-resources.ts.
4 tasks
This was
linked to
issues
Apr 28, 2021
attilah
approved these changes
Apr 29, 2021
|
Merging without mock test passing as it is a CCI issue and test has unrelated fixes. |
siegerts
added
the
referenced-in-release
|
👋 Hi, this issue was referenced in the v4.50.2 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.50.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
It is possible that older REST APIs have never been updated to include the
policyResourceNamefield on paths. This commit ensures that the field is present.Issue #, if available
#7190
#7201
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.