test(cli): add test for get-userpoolgroup-list.ts #7227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7227 +/- ##
==========================================
+ Coverage 52.28% 52.30% +0.01%
==========================================
Files 491 492 +1
Lines 25242 25251 +9
Branches 4952 4952
==========================================
+ Hits 13199 13208 +9
Misses 11091 11091
Partials 952 952
Continue to review full report at Codecov.
|
watilde
approved these changes
May 1, 2021
cjihrig
reviewed
May 1, 2021
| @@ -0,0 +1,43 @@ | |||
| import { getUserPoolGroupList } from '../../../../src/extensions/amplify-helpers/get-userpoolgroup-list'; | |||
There was a problem hiding this comment.
I think you can simplify this a bit:
Suggested change
| import { getUserPoolGroupList } from '../../../../src/extensions/amplify-helpers/get-userpoolgroup-list'; | |
| import { getUserPoolGroupList } from '../../../extensions/amplify-helpers/get-userpoolgroup-list'; |
There was a problem hiding this comment.
Thanks. I fixed it.
cjihrig
approved these changes
May 3, 2021
|
Thank you for the contribution! |
cjihrig
pushed a commit
to ctjlewis/amplify-cli
that referenced
this pull request
Jul 12, 2021
This commit adds a test for get-userpoolgroup-list.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Increase test coverage of amplify-cli.
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.