Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #4657 preserve previous authSelections in update flow #7255

Merged
merged 1 commit into from
May 4, 2021
Merged

fix: #4657 preserve previous authSelections in update flow #7255

merged 1 commit into from
May 4, 2021

Conversation

attilah
Copy link
Contributor

@attilah attilah commented May 4, 2021

Description of changes

Fix an update auth issue when update flow could end up enabling identity pool that leads to unintended resources during push.

Issue #, if available

fix: #4657 preserve previous authSelections in update flow

Description of how you validated changes

Manual testing

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@attilah attilah requested a review from a team as a code owner May 4, 2021 20:45
@attilah attilah requested a review from edwardfoyle May 4, 2021 20:46
@codecov-commenter
Copy link

Codecov Report

Merging #7255 (95193cf) into master (8775152) will decrease coverage by 4.15%.
The diff coverage is 45.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7255      +/-   ##
==========================================
- Coverage   56.43%   52.27%   -4.16%     
==========================================
  Files         445      491      +46     
  Lines       21859    25248    +3389     
  Branches     4373     4953     +580     
==========================================
+ Hits        12336    13199     +863     
- Misses       8745    11097    +2352     
- Partials      778      952     +174     
Impacted Files Coverage Δ
.../awscloudformation/utils/auth-defaults-appliers.ts 89.65% <0.00%> (ø)
...ls/awscloudformation/utils/synthesize-resources.ts 16.00% <ø> (ø)
packages/amplify-cli-core/src/deploymentState.ts 100.00% <ø> (ø)
...amplify-cli-core/src/feature-flags/featureFlags.ts 83.10% <ø> (ø)
...-cli/src/extensions/amplify-helpers/git-manager.ts 85.18% <ø> (ø)
.../amplify-frontend-ios/lib/amplify-config-helper.js 1.01% <ø> (ø)
...provider-awscloudformation/src/aws-utils/aws-s3.ts 9.32% <0.00%> (-0.77%) ⬇️
...ion/src/iterative-deployment/deployment-manager.ts 7.05% <0.00%> (ø)
...y-provider-awscloudformation/src/resourceParams.js 15.15% <ø> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b9569...95193cf. Read the comment docs.

@attilah attilah merged commit afbaa08 into aws-amplify:master May 4, 2021
@attilah attilah deleted the i4657 branch May 11, 2021 14:15
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label May 14, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v4.51.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v4.51.0.

cjihrig pushed a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identity Pool is added when adding redirect URIs
3 participants