Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): make sure to await returned promise from async functions #7379

Merged
merged 4 commits into from
Jun 21, 2021

Conversation

fossamagna
Copy link
Contributor

Description of changes

  • make sure to await returned promise from deleteResourceFiles.
  • make sure to await returned promise from emitError.
  • change to empty object form empty array as default value of questionOptions.serviceDeletionInfo
  • Increase test coverage of amplify-cli/extensions.

Issue #, if available

lerna --scope @aws-amplify/cli run test

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@fossamagna fossamagna requested a review from a team as a code owner May 21, 2021 14:53
@codecov-commenter
Copy link

Codecov Report

Merging #7379 (62481a8) into master (3dbb3bf) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7379      +/-   ##
==========================================
+ Coverage   52.72%   52.87%   +0.15%     
==========================================
  Files         513      514       +1     
  Lines       25914    25998      +84     
  Branches     5058     5074      +16     
==========================================
+ Hits        13662    13746      +84     
  Misses      11286    11286              
  Partials      966      966              
Impacted Files Coverage Δ
.../src/extensions/amplify-helpers/remove-resource.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbb3bf...62481a8. Read the comment docs.

@ammarkarachi ammarkarachi self-assigned this May 21, 2021
@ammarkarachi
Copy link
Contributor

@fossamagna thank you for your contribution! I will review this and get back to you

@edwardfoyle edwardfoyle merged commit af2a52a into aws-amplify:master Jun 21, 2021
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v5.0.2 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.0.2.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Jun 24, 2021
cjihrig pushed a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants