Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(graphql-transformers-e2e-tests): prevent SES ratelimit errors #7412

Merged
merged 1 commit into from
Jun 21, 2021
Merged

test(graphql-transformers-e2e-tests): prevent SES ratelimit errors #7412

merged 1 commit into from
Jun 21, 2021

Conversation

johnpc
Copy link
Contributor

@johnpc johnpc commented May 27, 2021

Description of changes

This commit prevents emails being sent when new users are created during e2e tests.

Without this commit, running e2e tests could cause this error:

Failed when signing up user
LimitExceededException: Exceeded daily email limit for the operation or the account. If a higher
limit is required, please configure your user pool to use your own Amazon SES configuration for
sending email.

Description of how you validated changes

I ran an integ test without this change. Failed with the above error. I then ran the same test with this change built in, and it passed.

Checklist

  • PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Without this commit, running e2e tests could cause this error: `Failed when signing up user
LimitExceededException: Exceeded daily email limit for the operation or the account. If a higher
limit is required, please configure your user pool to use your own Amazon SES configuration for
sending email.`
@johnpc johnpc requested a review from a team as a code owner May 27, 2021 17:28
@codecov-commenter
Copy link

Codecov Report

Merging #7412 (0bb513a) into master (be441c9) will increase coverage by 0.00%.
The diff coverage is 64.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7412   +/-   ##
=======================================
  Coverage   52.74%   52.75%           
=======================================
  Files         514      514           
  Lines       25919    25916    -3     
  Branches     5059     5056    -3     
=======================================
  Hits        13672    13672           
+ Misses      11280    11277    -3     
  Partials      967      967           
Impacted Files Coverage Δ
...ider-awscloudformation/src/display-helpful-urls.js 16.90% <33.33%> (+0.35%) ⬆️
...wscloudformation/utils/auth-sms-workflow-helper.ts 45.45% <80.00%> (+21.64%) ⬆️
...r-utils/awscloudformation/utils/message-printer.ts 50.00% <100.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53c115f...0bb513a. Read the comment docs.

@cjihrig cjihrig self-assigned this May 27, 2021
@edwardfoyle edwardfoyle merged commit 632fd67 into aws-amplify:master Jun 21, 2021
cjihrig pushed a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
…ws-amplify#7412)

Without this commit, running e2e tests could cause this error: `Failed when signing up user
LimitExceededException: Exceeded daily email limit for the operation or the account. If a higher
limit is required, please configure your user pool to use your own Amazon SES configuration for
sending email.`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants