Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update AMPLIFY_PATH env var in config for migration tests #7497

Merged
merged 2 commits into from
Jun 10, 2021
Merged

chore: update AMPLIFY_PATH env var in config for migration tests #7497

merged 2 commits into from
Jun 10, 2021

Conversation

jhockett
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jhockett jhockett requested a review from a team as a code owner June 10, 2021 01:32
attilah
attilah approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@attilah attilah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: as a better solution later we could use the output of npm config get prefix to get the base for global.

@jhockett jhockett merged commit 4f8b5b6 into aws-amplify:master Jun 10, 2021
@jhockett jhockett deleted the migration-config-update branch June 10, 2021 03:10
cjihrig pushed a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
@jhockett @cjihrig-aws
chore: update AMPLIFY_PATH env var in config for migration tests (aws…
6d32793 
…-amplify#7497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attilah attilah attilah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhockett @attilah