fix: copy env specific data from ccb on env checkout #7512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attilah
reviewed
Jun 14, 2021
packages/amplify-category-function/src/provider-utils/awscloudformation/index.ts
Outdated
Show resolved
Hide resolved
attilah
reviewed
Jun 14, 2021
packages/amplify-category-function/src/provider-utils/awscloudformation/index.ts
Outdated
Show resolved
Hide resolved
attilah
approved these changes
Jun 14, 2021
github-actions
bot
added
the
referenced-in-release
|
👋 Hi, this pull request was referenced in the v5.0.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.0.0. |
cjihrig
pushed a commit
to ctjlewis/amplify-cli
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
After an
amplify env checkout, the displayedamplify statuswould sometimes incorrectly show Updated instead of No Changes when layer content remained untouched. This PR fixes that by copying the Cloudformation file and the description field stored in the#current-cloud-backenddirectory. This bug only affected the displayed status, and did not result in new layer versions being created on a subsequent push.Also updated an inaccurate e2e test description.
Description of how you validated changes
Updated multi-environment e2e tests to check
amplify status, which pass locally. Unit tests also pass locally.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.