Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change scope of change detection for python layers #7545

Merged
merged 1 commit into from
Jun 18, 2021
Merged

fix: change scope of change detection for python layers #7545

merged 1 commit into from
Jun 18, 2021

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Jun 18, 2021

Description of changes

Change the scope of files the CLI checks for python lambda layers.

Now in the layer directory the following files are checked:

  • Pipfile (if exists)
  • Pipfile.lock (if exists)
  • All other files recursively, but exluding lib - where pip install installs the dependencies

Issue #, if available

N/A

Description of how you validated changes

Manual testing

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@attilah attilah requested a review from yuth June 18, 2021 19:01
@attilah attilah requested a review from a team as a code owner June 18, 2021 19:01
@codecov-commenter
Copy link

Codecov Report

Merging #7545 (66c80e2) into master (c3f4128) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7545   +/-   ##
=======================================
  Coverage   52.77%   52.77%           
=======================================
  Files         523      523           
  Lines       26155    26155           
  Branches     5117     5117           
=======================================
  Hits        13804    13804           
  Misses      11382    11382           
  Partials      969      969           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f4128...66c80e2. Read the comment docs.

@attilah attilah merged commit a23ab9b into aws-amplify:master Jun 18, 2021
@attilah attilah deleted the layerpythonchangedetection branch June 18, 2021 19:58
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v5.0.1 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.0.1.

@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Jun 19, 2021
cjihrig pushed a commit to ctjlewis/amplify-cli that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants