Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-appsync-simulator): string functions not called on items … #7636

Merged
merged 5 commits into from
Jul 12, 2021
Merged

fix(amplify-appsync-simulator): string functions not called on items … #7636

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8bea0cc
fix(amplify-appsync-simulator): string functions not called on items …
alichherawalla Jun 30, 2021
c5c6bed
Merge branch 'master' of https://github.com/aws-amplify/amplify-cli
alichherawalla Jul 2, 2021
9b8ab5a
feat(amplify-appsync-simulator): added toJavaString that accepts a st…
alichherawalla Jul 2, 2021
775b4c1
feat(amplify-appsync-simulator): map.keySet returns an a JavaArray wi…
alichherawalla Jul 2, 2021
baac61f
feat(amplify-appsync-simulator): using this.mapper in map.keySet
alichherawalla Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/amplify-appsync-simulator/src/velocity/value-mapper/array.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { JavaString } from './string';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think importing JavaString is the correct way to go here. The mapper argument passed to the constructor can do this for you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey,

Thank you for taking the time to review this.

Will take a look at how this can be done using the mapper, and will also add tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cjihrig,

I've made the changes, please do let me know if there is anything else that would be required.

Thank you for your time.

import { toJSON } from './to-json';

export class JavaArray extends Array<any> {
Expand All @@ -7,6 +8,13 @@ export class JavaArray extends Array<any> {
// splice sends a single object
values = [values];
}
values = values.map(value => {
if (typeof value === 'string' && !((value as any) instanceof JavaString)) {
return new JavaString(value);
}
return value;
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note here, but the indentation is off.


if (values.length !== 1) {
super(...values);
} else {
Expand Down