feat(cli): add consistent support for verb / noun swapping #7675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commands in the 'core' plugin that contain sub-commands (env and plugin) now support verb / noun swapping (`env add` and `add env` now both work) close aws-amplify#7630
cjihrig
reviewed
Jul 9, 2021
…Property() Changed validation checks per requests in PR aws-amplify#7675
Codecov Report
@@ Coverage Diff @@
## master #7675 +/- ##
=======================================
Coverage 51.79% 51.79%
=======================================
Files 547 547
Lines 27626 27626
Branches 5342 5342
=======================================
Hits 14308 14308
Misses 12326 12326
Partials 992 992 Continue to review full report at Codecov.
|
cjihrig
approved these changes
Aug 25, 2021
jhockett
pushed a commit
that referenced
this pull request
Aug 25, 2021
* feat(cli): add consistent support for verb / noun swapping commands in the 'core' plugin that contain sub-commands (env and plugin) now support verb / noun swapping (`env add` and `add env` now both work) close #7630 * refactor(cli): improve validation checks - Array.isArray() and hasOwnProperty() Changed validation checks per requests in PR #7675
|
👋 Hi, this pull request was referenced in the v5.4.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.4.0. |
github-actions
bot
added
the
referenced-in-release
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
…fy#7675) * feat(cli): add consistent support for verb / noun swapping commands in the 'core' plugin that contain sub-commands (env and plugin) now support verb / noun swapping (`env add` and `add env` now both work) close aws-amplify#7630 * refactor(cli): improve validation checks - Array.isArray() and hasOwnProperty() Changed validation checks per requests in PR aws-amplify#7675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Commands in the 'core' plugin that contain sub-commands (env and plugin) now support verb / noun
swapping (i.e.
env addandadd envnow both work).Issue #, if available
close #7630
Description of how you validated changes
Manually tested in sample Amplify project using
amplify-dev:amplify-dev add envamplify-dev remove pluginapi addandadd apistill workyarn testyarn lintChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.