Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip unnecessary prompt for 'amplify update function' #7755

Merged
merged 2 commits into from
Jul 21, 2021
Merged

skip unnecessary prompt for 'amplify update function' #7755

merged 2 commits into from
Jul 21, 2021

Conversation

johnpc
Copy link
Contributor

@johnpc johnpc commented Jul 20, 2021

Description of changes

When calling amplify update function, the user is prompted to select whether they want to update a lambda function or lambda layer. This prompt should be skipped if only one of the two exist, and it should default as though option that exists was selected.

Issue #, if available

#7308

Description of how you validated changes

  • manually tested case where only a function exists
  • manually tested case where only a layer exists
  • manually tested case where both exist
  • manually tested case where neither exists
  • added unit tests
  • updated e2e test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@johnpc johnpc requested a review from a team as a code owner July 20, 2021 16:54
@jhockett jhockett self-assigned this Jul 21, 2021
Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants