fix(amplify-category-function): include files starting with a period on packaging #7861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I use prisma(https://www.prisma.io/) with lambda function and it creates node_modules/.prisma folder to add query-engines. When packaging process, Amplify does not include this folder into build.zip . Adding `dot: true` option to archiver will solve this issue. I hope you will find this useful.
Codecov Report
@@ Coverage Diff @@
## master #7861 +/- ##
=======================================
Coverage 53.27% 53.27%
=======================================
Files 555 555
Lines 28051 28051
Branches 5442 5442
=======================================
Hits 14945 14945
Misses 12121 12121
Partials 985 985 Continue to review full report at Codecov.
|
siegerts
added
the
first-time-contributor
edwardfoyle
approved these changes
Aug 17, 2021
Closed
4 tasks
jhockett
pushed a commit
that referenced
this pull request
Aug 25, 2021
I use prisma(https://www.prisma.io/) with lambda function and it creates node_modules/.prisma folder to add query-engines. When packaging process, Amplify does not include this folder into build.zip . Adding `dot: true` option to archiver will solve this issue. I hope you will find this useful.
|
👋 Hi, this pull request was referenced in the v5.4.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.4.0. |
github-actions
bot
added
the
referenced-in-release
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
) I use prisma(https://www.prisma.io/) with lambda function and it creates node_modules/.prisma folder to add query-engines. When packaging process, Amplify does not include this folder into build.zip . Adding `dot: true` option to archiver will solve this issue. I hope you will find this useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I use prisma with lambda function and it creates node_modules/.prisma folder to add query-engines. When packaging process, Amplify does not include this folder into build.zip . Adding
dot: trueoption to archiver will solve this issue. But it will copy the unwanted files which is starting with period like.env. So I am not sure this is the best solution. I hope you will find this useful.Description of how you validated changes
Manual
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.