Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql-model-transformer): added @model name reserved words validation #7865

Closed
wants to merge 86 commits into from
Closed

fix(graphql-model-transformer): added @model name reserved words validation #7865

wants to merge 86 commits into from

Conversation

lazpavel
Copy link
Contributor

@lazpavel lazpavel commented Aug 3, 2021

Description of changes

Added name validation for @model type name against the reserved words. Changes are made on top of #7857

Description of how you validated changes

  • ran yarn test
  • migrated unit test from graphql-dynamodb-transformer
  • manual debugging and testing
  • CircleCI build_test_deploy job

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lazpavel and others added 24 commits July 8, 2021 14:19
…ields type

Converted fields of input type objects to also be of input type. Small typo fixes.
@lazpavel lazpavel requested a review from a team as a code owner August 3, 2021 18:22
SwaySway and others added 5 commits August 3, 2021 12:01
* Add .circleci/config.yml

* test: ported @model v1 test suite to v2

* chore(graphql-model-transformer): removed improvePluralization check, V2 uses improvePluralization

* chore(graphql-model-transformer): added parse() to tests that generate a valid schema

* test(graphql-model-transformer): added validateModelSchema check to existing model v2 tests

* fix(graphql-model-transformer): fixed @model transform input object fields type

Converted fields of input type objects to also be of input type. Small typo fixes.

* Add .circleci/config.yml

* Add .circleci/config.yml

* chore(graphql-model-transformer): removed test for deprecated @model feature flag
since cfn-lint is deprecated, it does not always proper validate cloudformation. we've made validation errors non-blocking already in [#7132](#7132). This commit also addresses the log level so as not to confuse customers with a red error message.

#7831
…function (#7785)

* fix(7718) Storage env vars not added to lambda function

* unit-tests

Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com>
@lazpavel lazpavel marked this pull request as draft August 4, 2021 02:54
@lazpavel lazpavel closed this Aug 4, 2021
@lazpavel lazpavel deleted the model-name-validation branch August 4, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants