Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graphql-model-transformer): implemented support for nested non model fields #7884

Closed
wants to merge 79 commits into from
Closed

fix(graphql-model-transformer): implemented support for nested non model fields #7884

wants to merge 79 commits into from

Conversation

pavellazar
Copy link
Contributor

Description of changes

Description of how you validated changes

  • yarn test passes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pavellazar pavellazar requested a review from a team as a code owner August 4, 2021 17:44
@pavellazar pavellazar changed the title Non model types fix(graphql-model-transformer): implemented support for nested non model fields Aug 4, 2021
@pavellazar pavellazar mentioned this pull request Aug 4, 2021
Closed
3 tasks
@cjihrig
Copy link
Contributor

cjihrig commented Aug 7, 2021

Can you rebase this please.

@pavellazar
fix(graphql-model-transformer): implemented support for nested non mo…
ab58a00 
…del fields
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
2c929b9 
… enum types
@pavellazar
Merge branch 'non-model-types' of github.com:lazpavel/amplify-cli int…
8f00ceb 
…o non-model-types
@pavellazar
fix(graphql-model-transformer): implemented support for nested non mo…
381dce7 
…del fields
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
af16224 
… enum types
@pavellazar
chore(graphql-model-transformer): fixed merge conflicts
837af84
@pavellazar
fix(graphql-model-transformer): implemented support for nested non mo…
5d0efd5 
…del fields
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
06eb296 
… enum types
@pavellazar
chore(graphql-model-transformer): fixed merge conflicts
fcd436d
@pavellazar pavellazar changed the base branch from master to 2493-clear-require-cache-between-lambda-invocations August 8, 2021 03:42
@pavellazar pavellazar changed the base branch from 2493-clear-require-cache-between-lambda-invocations to master August 8, 2021 03:42
cjihrig
cjihrig approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a call to validateModelSchema() in the test. Other than that, LGTM.

@cjihrig
Copy link
Contributor

cjihrig commented Aug 9, 2021 •
edited
Loading

It looks like LGTM bot is having some issues with this PR as well.

@cjihrig cjihrig self-assigned this Aug 9, 2021
@pavellazar
fix(graphql-model-transformer): implemented support for nested non mo…
1035629 
…del fields
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
3d77664 
… enum types
@pavellazar
fix(graphql-model-transformer): implemented support for nested non mo…
b7b6153 
…del fields
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
93af998 
… enum types
@pavellazar
chore(graphql-model-transformer): added validateModelSchema to unit test
2c44f34
@pavellazar
chore(graphql-model-transformer): added validateModelSchema to unit test
d8601a3
@pavellazar
fix(graphql-model-transformer): implemented support for nested non mo…
85cf061 
…del fields
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
bfe2bd2 
… enum types
@pavellazar
fix(graphql-model-transformer): implemented support for nested non mo…
14eb758 
…del fields
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
05b4559 
… enum types
@pavellazar
fix(graphql-model-transformer): implemented support for nested non mo…
8bad3ca 
…del fields
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
e11a526 
… enum types
@pavellazar
fix(graphql-model-transformer): implemented support for nested non mo…
81851a9 
…del fields
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
e8a30c9 
… enum types
@pavellazar
chore(graphql-model-transformer): added validateModelSchema to unit test
b47fdba
@pavellazar
chore(graphql-model-transformer): fixed merge conflicts
24e2c0a
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
22c1fc7 
… enum types
@pavellazar
fix(graphql-model-transformer): implemented support for nested non mo…
07c0e6f 
…del fields
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
4b9b722 
… enum types
@pavellazar
fix(graphql-model-transformer): implemented support for nested non mo…
68150eb 
…del fields
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
6e65b61 
… enum types
@pavellazar
fix(graphql-model-transformer): implemented support for nested non mo…
c307f7b 
…del fields
@pavellazar
fix(graphql-model-transformer): fixed input type field generation for…
0ed5354 
… enum types
@pavellazar
chore(graphql-model-transformer): added validateModelSchema to unit test
a8258ba
@pavellazar
Merge branch 'non-model-types' of github.com:lazpavel/amplify-cli int…
ba0d0d8 
…o non-model-types
@pavellazar
chore(graphql-model-transformer): fixed merge conflicts
f39b379
@pavellazar pavellazar changed the base branch from master to 2493-clear-require-cache-between-lambda-invocations August 16, 2021 18:17
@pavellazar pavellazar changed the base branch from 2493-clear-require-cache-between-lambda-invocations to master August 16, 2021 18:17
@pavellazar pavellazar closed this Aug 16, 2021
@pavellazar
Copy link
Contributor Author

already merged as part of #7927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees

@cjihrig cjihrig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavellazar @cjihrig