Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "feat(amplify-category-auth): use EnabledMFAs to only configure TOTP"" #7971

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

ammarkarachi
Copy link
Contributor

Reverts #7790

Waiting on downstream changes to merge

@ammarkarachi ammarkarachi requested a review from a team as a code owner August 16, 2021 21:57
@codecov-commenter
Copy link

Codecov Report

Merging #7971 (c188d9e) into master (e34bfbe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7971   +/-   ##
=======================================
  Coverage   53.70%   53.71%           
=======================================
  Files         563      563           
  Lines       28554    28555    +1     
  Branches     5541     5541           
=======================================
+ Hits        15336    15337    +1     
  Misses      12221    12221           
  Partials      997      997           
Impacted Files Coverage Δ
...ils/awscloudformation/service-walkthrough-types.ts 100.00% <ø> (ø)
...amplify-cli-core/src/feature-flags/featureFlags.ts 83.10% <ø> (ø)
.../awscloudformation/utils/auth-defaults-appliers.ts 90.00% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e34bfbe...c188d9e. Read the comment docs.

@ammarkarachi ammarkarachi force-pushed the revert-7790-revert-7779-fix/totp-mfa branch from c188d9e to afd8818 Compare October 25, 2021 18:08
Copy link
Contributor

@lazpavel lazpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ammarkarachi ammarkarachi merged commit ff418d1 into master Oct 26, 2021
@danielleadams danielleadams deleted the revert-7790-revert-7779-fix/totp-mfa branch December 15, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants